From: David Howells <dhowells@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/4] rxrpc: Fix missing active use pinning of rxrpc_local object
Date: Mon, 03 Feb 2020 10:23:44 +0000 [thread overview]
Message-ID: <734244.1580725424@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200202122735.157d8b44@cakuba.hsd1.ca.comcast.net>
Jakub Kicinski <kuba@kernel.org> wrote:
> > + BUG_ON(!conn->params.local);
> > + BUG_ON(!conn->params.local->socket);
>
> Is this really, really not possible to convert those into a WARN_ON()
> and return?
I can take those out - I actually put them in to help figure out which pointer
had become NULL - but turning them into a WARN_ON() and return doesn't
actually help that much since, without this patch, there was nothing to stop
the relevant pointer getting cleared between this point and the next access,
so there's a chance you'd end up with the same oops anyway.
David
next prev parent reply other threads:[~2020-02-03 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 13:29 [PATCH net 0/4] rxrpc: Fixes David Howells
2020-01-31 13:29 ` [PATCH net 1/4] rxrpc: Fix use-after-free in rxrpc_put_local() David Howells
2020-01-31 13:29 ` [PATCH net 2/4] rxrpc: Fix insufficient receive notification generation David Howells
2020-01-31 13:29 ` [PATCH net 3/4] rxrpc: Fix missing active use pinning of rxrpc_local object David Howells
2020-02-02 20:27 ` Jakub Kicinski
2020-02-03 10:23 ` David Howells [this message]
2020-01-31 13:29 ` [PATCH net 4/4] rxrpc: Fix NULL pointer deref due to call->conn being cleared on disconnect David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734244.1580725424@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®