From: dinghao.liu@zju.edu.cn
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: "Konstantin Ryabitsev" <konstantin@linuxfoundation.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
kjlu@umn.edu, "David S. Miller" <davem@davemloft.net>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe
Date: Thu, 7 Jan 2021 15:54:15 +0800 (GMT+08:00) [thread overview]
Message-ID: <73439f2d.25481.176dbd6c8ea.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20210106084430.291a90cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao.liu@zju.edu.cn
> wrote:
> > > I used this one for a test:
> > >
> > > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com/
> > >
> > > I'm not getting the Fixes tag when I download the mbox.
> >
> > It seems that automatically generating Fixes tags is a hard work.
> > Both patches and bugs could be complex. Sometimes even human cannot
> > determine which commit introduced a target bug.
> >
> > Is this an already implemented functionality?
>
> I'm not sure I understand. Indeed finding the right commit to use in
> a Fixes tag is not always easy, and definitely not easy to automate.
> Human validation is always required.
>
> If we could easily automate finding the commit which introduced a
> problem we wouldn't need to add the explicit tag, backporters could
> just run such script locally.. That's why it's best if the author
> does the digging and provides the right tag.
>
> The conversation with Konstantin and Florian was about automatically
> picking up Fixes tags from the mailing list by the patchwork software,
> when such tags are posted in reply to the original posting, just like
> review tags. But the tags are still generated by humans.
It's clear to me, thanks.
Regards,
Dinghao
prev parent reply other threads:[~2021-01-07 7:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 11:06 Dinghao Liu
2020-12-23 15:33 ` Andrew Lunn
2020-12-23 20:32 ` Jakub Kicinski
2020-12-23 21:00 ` Andrew Lunn
2020-12-23 21:11 ` Jakub Kicinski
2020-12-23 22:17 ` Florian Fainelli
2020-12-24 1:41 ` Jakub Kicinski
2020-12-24 18:06 ` Konstantin Ryabitsev
2020-12-24 21:57 ` Florian Fainelli
2020-12-28 20:23 ` Konstantin Ryabitsev
2020-12-28 21:05 ` Florian Fainelli
2020-12-28 21:14 ` Konstantin Ryabitsev
2020-12-30 21:36 ` Jakub Kicinski
2021-01-06 10:56 ` dinghao.liu
2021-01-06 16:44 ` Jakub Kicinski
2021-01-07 7:54 ` dinghao.liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73439f2d.25481.176dbd6c8ea.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kjlu@umn.edu \
--cc=konstantin@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®