From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<mathieu.poirier@linaro.org>, <konrad.dybcio@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: qcom: fix sparse warnings
Date: Sun, 12 Feb 2023 21:41:04 +0530 [thread overview]
Message-ID: <73474906-8376-9328-16c2-370a87477c6a@quicinc.com> (raw)
In-Reply-To: <1675180866-16695-1-git-send-email-quic_mojha@quicinc.com>
Friendly reminder.
-Mukesh
On 1/31/2023 9:31 PM, Mukesh Ojha wrote:
> This patch try to address below sparse warnings.
>
> drivers/remoteproc/qcom_common.c:126:27: warning: restricted __le32 degrades to integer
> drivers/remoteproc/qcom_common.c:133:32: warning: cast to restricted __le32
> drivers/remoteproc/qcom_common.c:133:32: warning: cast from restricted __le64
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> drivers/remoteproc/qcom_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
> index 020349f..7133c1f 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -123,14 +123,14 @@ static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsy
>
> for (i = 0; i < seg_cnt; i++) {
> memcpy_fromio(®ion, ptr + i, sizeof(region));
> - if (region.valid == MD_REGION_VALID) {
> + if (le32_to_cpu(region.valid) == MD_REGION_VALID) {
> name = kstrdup(region.name, GFP_KERNEL);
> if (!name) {
> iounmap(ptr);
> return -ENOMEM;
> }
> da = le64_to_cpu(region.address);
> - size = le32_to_cpu(region.size);
> + size = le64_to_cpu(region.size);
> rproc_coredump_add_custom_segment(rproc, da, size, NULL, name);
> }
> }
next prev parent reply other threads:[~2023-02-12 16:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 16:01 Mukesh Ojha
2023-02-12 16:11 ` Mukesh Ojha [this message]
2023-02-13 0:55 ` Dmitry Baryshkov
2023-02-14 14:12 ` Mukesh Ojha
2023-02-14 14:08 ` [PATCH] remoteproc: qcom: replace kstrdup with kstrndup Mukesh Ojha
2023-02-14 16:39 ` Bjorn Andersson
2023-02-15 5:16 ` Mukesh Ojha
2023-02-14 17:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73474906-8376-9328-16c2-370a87477c6a@quicinc.com \
--to=quic_mojha@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®