From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdAaKLJ (ORCPT ); Tue, 31 Jan 2017 05:11:09 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:40560 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdAaKKZ (ORCPT ); Tue, 31 Jan 2017 05:10:25 -0500 Subject: Re: [PATCH 14/17] net: stmmac: print phy information To: Corentin Labbe , , References: <20170131091152.13842-1-clabbe.montjoie@gmail.com> <20170131091152.13842-15-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: <734d7c1c-bf82-c723-59b8-2abd003dc6d7@st.com> Date: Tue, 31 Jan 2017 11:10:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170131091152.13842-15-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG4NODE1.st.com (10.75.127.10) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-31_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/31/2017 10:11 AM, Corentin Labbe wrote: > When a PHY is found, printing which one was found (and which type/model) is > a good information to know. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index e53b727..3d52b8c 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -885,6 +885,7 @@ static int stmmac_init_phy(struct net_device *dev) > netdev_dbg(priv->dev, "%s: attached to PHY (UID 0x%x) Link = %d\n", > __func__, phydev->phy_id, phydev->link); > > + phy_attached_info(phydev); maybe we could remove the netdev_dbg above and just keep phy_attached_info(phydev); peppe > return 0; > } > >