From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 585DBC433FE for ; Wed, 30 Mar 2022 15:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348386AbiC3PuC (ORCPT ); Wed, 30 Mar 2022 11:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344628AbiC3PuA (ORCPT ); Wed, 30 Mar 2022 11:50:00 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA07920E942; Wed, 30 Mar 2022 08:48:10 -0700 (PDT) X-UUID: 3b656cbffa5f4f99900f5d676e1ba9e7-20220330 X-UUID: 3b656cbffa5f4f99900f5d676e1ba9e7-20220330 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1049488280; Wed, 30 Mar 2022 23:48:03 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 30 Mar 2022 23:48:02 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 30 Mar 2022 23:48:01 +0800 Message-ID: <734fbf254c64668856e987aafe9d7dfd3ec86941.camel@mediatek.com> Subject: Re: [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker From: Jiaxin Yu To: Mark Brown CC: "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" , , , , , , , , , , , , , , Tzung-Bi Shih Date: Wed, 30 Mar 2022 23:48:01 +0800 In-Reply-To: References: <20220324064511.10665-1-jiaxin.yu@mediatek.com> <20220324064511.10665-3-jiaxin.yu@mediatek.com> <20220329223002.uo7kiemopkh7ak4x@notapiano> <61e9fb59448837cfc8e3ec862b711294bcb68872.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-03-30 at 15:24 +0100, Mark Brown wrote: > On Wed, Mar 30, 2022 at 10:06:24PM +0800, Jiaxin Yu wrote: > > On Wed, 2022-03-30 at 13:30 +0100, Mark Brown wrote: > > > Making a previously optional property required means that systems > > > that > > > previously worked may stop working unless they update their DT, > > > DTs > > > may > > > be distributed separately to the kernel and perhaps even baked > > > into > > > firmware or similar. > > Thank you for your detailed answer. I should keep the driver's > > behavior > > consistent with the description of dt-bindings. The "mediatek,hdmi- > > codec" needs to be set as the required property. Is my > > understanding > > right? > > The binding document and code should match so if one is changed the > other needs to be changed too. > > In theory we should never change a previously optional property to > required which would mean that the code should be updated to reflect > the > binding document, however sometimes the DT isn't actually used as a > stable intereface by anything for a given property or device type so > we > can get away with changing things. "however sometimes the DT isn't actually used as a stable intereface by anything for a given property or device type so we can get away with changing things." Sorry, I don't understand the real idea of this description. Does it mean that dt-bindings in this series don't need to be updated, but the driver?