From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C45D279334 for ; Thu, 8 Jan 2026 09:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865621; cv=none; b=HLF78bvtMjVsvntOAONAKia77RZqzfcUoVjh+ZqOyr5G9kyjxbAFWinHcEVw0FcG+/r4GeU7p6wyATIlliqZzkdrT8AVuEHlZ+iy43kMJUHEBp828iGjjSwwCaZObr6Owg0q9xc3K9lEm6OI2zgkg++EtEfg2VEyN7wkvZgZQS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865621; c=relaxed/simple; bh=kyS735lkzRm6iP9gLn878Rc7C/XLkvz6f+70xRRIC88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OYWjvMjuAsrJ1iTJLoNs77YENbOBq0uBz9NHq8871ZZ2qWe+dDMYZlZb4xXxABM5PfdgnrpDY1YO9n85OpEe7aEKYoaoisWGUbV+AXEjm0S9gxKDpEKoQiKv76pj/0MjLD9PqtbxfX8cYHz/7wyDsPXMaDMlj/RUokQv7LkCW1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dY4AhZT4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X0eYSTaq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dY4AhZT4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X0eYSTaq" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60872H5P1496293 for ; Thu, 8 Jan 2026 09:46:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B7V3RcisA+op3cY+VwOP9SxMwcFSGf1FmApbA3k+wkc=; b=dY4AhZT490YJjHcb smBudkm+YGRizvHAt8fVw6uroZVavNUnkgkO3S1LRKFoPOnOMt20qnXbGzY81eLu GZi/7U0Eb81+x7Ogeoe6K+OXJ11NzBItVkqpu6/aNFkwoO07R3oZWGykjxWE3ZTB dXt9bKlklZlMduNGy7A6dpmx6gLhhAaEpD1KaCxhHTbsoG5/7AOfXmFvbHiotTXf 3PPf9vL/XvPAhJo3C9BNk4W3ggJQrV3ppPpJwUAJuqX//VQAVXVB6lHqPAaKROMa W4stTbyq5KlNyzCseN/whb4Ya557uGlWjHxqAPwbE+s6FB9K4sWWFbJttvmwTwsl NOe/1w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bj7ua8fyt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Jan 2026 09:46:48 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b9c91b814cso6404675b3a.2 for ; Thu, 08 Jan 2026 01:46:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767865608; x=1768470408; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B7V3RcisA+op3cY+VwOP9SxMwcFSGf1FmApbA3k+wkc=; b=X0eYSTaqQO05gqOYnw50YaHwRKXCNRNo0BdSWbhIOpVxhNv8kLWZjGP1BjRCw9sjrn 06HwZZ6cP3MdrX3ioeh6DKPvtPk7upxmDs7Ll1LJnpc/gDpcOkUFDWa4wOql46TPo5Oq DV0xN/TVPDiSHCiRs6hi5b7y7zcJ4z8g6ZJo3eeGAoZkm5Bhv4K3tESi8vjutGbqZb8Y SPO6XLE7J/D3yx8ENZt615ZhuR6Lo9/BC6SnIVyddmJ5G9bkQfNUuHdGqMddrZbumm9U dd2dqaGKRbdKP1CKju3zut/Dd0LrAqMcF6kw1uOKTF8rVQ10OWCC+3FtOtS4Yw/CJSh7 3NOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767865608; x=1768470408; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B7V3RcisA+op3cY+VwOP9SxMwcFSGf1FmApbA3k+wkc=; b=eN/zU53J19Pc7A1+ndzICCssZ+4KHJ8xtSfN7b/pBG5pZ+al2PZykpUdcrpw9khfzl x5v85rO3LAwcx475ujxz8kWziYHfHbWjut6DQY8ZuHRbkVB98T0iSyQsXSqxYGfTFJYv WVZCC04pfEDFSGyFxidv88qBGmA6gTm1q0e98QKwn+I7xzQw13e56tjHkHfgAaLoQeSp SsZLsOEylt3aaX8erYaPFFVavN0U90YnPQB4nTpgzG5hjhtUy3U9AvTqrex6Zuk+xJcJ V4iD+28dCEzo3+yIQzVwy+cLJrl3vDueAbFIb6dHCNQXhWZtwK7uJe8BwBwdQl10VKxh lkDA== X-Forwarded-Encrypted: i=1; AJvYcCWUZ/7DjVzwpYPKt0GZQoQz3YGQ9VA+hfczfLafmKd1FQgn4H+dhup8g03zVczVTYyiUck+fsXx6+lVo/s=@vger.kernel.org X-Gm-Message-State: AOJu0YzB082uYinXpsgF0DjCTG9T4HRBtMa58lucb8NfRgdqkd+hJjZT pOsPyqRxNizpBCA5KldsJGyWvIWtiyjBPYZ/GEAYmwo0aV9YSRBPuaXXox92HN73f33glyPA7n5 rr8so7+/WH5PFDwuGmkot4yNC2BKxfKZDOVMf9AMfoKNRKZ91Y5mFw/3oeAp3uIEZsmc= X-Gm-Gg: AY/fxX6WeVQhE77QRILN0Xlue8P9KUz8E3oWFPXnHQxeOVmEYDLAiwDChuVkASJwl48 L44YOxVWheEDUTBd3txAg9BesJH2bNVjpEpMGd2UGqFguVRTr1cgkdINlyotwaGyqTqWn15bFmF TtHWXP1gNUSniQS4MOG6YaYlp2EP9+zLssKKM1fqY0AV3HHpT/4uPDsy2WHFTEIZfORItVQ1TNE PeD0+Fi8StoO34+eZsdXQP9f5Z7AptN1fYKd3y6gCvPnE908rQFHNpcTbHoBwAST0igt+bxpO1x 3pzZVgNi27KEoNwWxbqik7Oi0r+qog+M6Tpr/dhZQsKD8SEv/4swyQw0xGRBbHoiZBGb9kcSx5f tm82XPh7iLAD8/p4fW4fYstFyGtnV9O79fYpxXZY= X-Received: by 2002:a05:6a00:8007:b0:7a2:7a93:f8c9 with SMTP id d2e1a72fcca58-81b7de6086fmr5353469b3a.27.1767865607668; Thu, 08 Jan 2026 01:46:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMZpHyMO+jdm/lDEV75xA0kO2dYVAcx5zTcm+aIoS8vyPZx1Jc5H2YpY2OAqdGeFrva6OiKw== X-Received: by 2002:a05:6a00:8007:b0:7a2:7a93:f8c9 with SMTP id d2e1a72fcca58-81b7de6086fmr5353457b3a.27.1767865607191; Thu, 08 Jan 2026 01:46:47 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c52f8b0csm7224645b3a.35.2026.01.08.01.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 01:46:46 -0800 (PST) Message-ID: <735267c2-91df-41cb-9b53-97f8cb0fa8fa@oss.qualcomm.com> Date: Thu, 8 Jan 2026 15:16:42 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: defconfig: Enable QCOMTEE on Qualcomm SM8650+ To: Bjorn Andersson Cc: Sumit Garg , Bjorn Andersson , Dmitry Baryshkov , Krzysztof Kozlowski , Konrad Dybcio , Jens Wiklander , Amirreza Zarrabi , Arnd Bergmann , Geert Uytterhoeven , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <309e0391-58a3-466b-a113-ab864188f6fe@kernel.org> <05581cbd-dfcc-41ac-9020-b1590b8ed7a8@oss.qualcomm.com> <0a4368bf-40a2-42bb-b538-6e64c11598e3@oss.qualcomm.com> <5a064c67-2c15-4ab9-ad34-a56a2e0ec150@oss.qualcomm.com> <83ec99c3-ab34-4344-ac60-084a85e4fb2a@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDA2NCBTYWx0ZWRfXynYqCnIFOud6 f8RL1v8o7WdsQvqXZdm8Fs5w3A1oxnLiZ/g+QkqLkFwa8eytPJAYiD45lYxZQHpD2fmgjeeao/E ATqUtQfpFUHE3Jmgc6GkoMTIZukdGfAx7s4MRi3aNDKNbslEaWG5sXwc1mralo4lLqUYI5D6fwF hl9CmVHvCSkhWxZccjPCWTgZ8fFSK8acNLQwDXFA5B+Cr2IUGakh2PaZVycy67OFoTItDKLCsKJ y33wY4IvhosvXrKPUEx26ZRDWPI6Me9QuqhaZYYC+X+h9b7ZQhQG6y0FgTaLh3sjRAV+rqpnPgD Ckl3FkX0qfWukyahVyPkhTZhHEAUcdwYUXDtTUqR2BQv36LGg9UNolZIlPdIfTSRJUEMgXRZTCF mom5W7G9fkiSLVCFNe3oWdQA7HJsT/VlsVTlGbMl26JOiEHGkyEi70n3vjXPw3B88Z5OGfAnT7M xQQNZypTXh/iJnjCLVg== X-Proofpoint-GUID: hfjVRVwGKMT3BULYlQlBvXvIUuqiMJPZ X-Proofpoint-ORIG-GUID: hfjVRVwGKMT3BULYlQlBvXvIUuqiMJPZ X-Authority-Analysis: v=2.4 cv=XMM9iAhE c=1 sm=1 tr=0 ts=695f7d08 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=P-IC7800AAAA:8 a=NEAV23lmAAAA:8 a=420Oibe_mZBiAEJleGoA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_02,2026-01-07_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601080064 Hi, On 1/7/2026 8:34 PM, Bjorn Andersson wrote: > On Wed, Jan 07, 2026 at 11:50:33AM +0530, Harshal Dev wrote: >> Hi, >> >> On 1/2/2026 11:53 PM, Bjorn Andersson wrote: >>> On Fri, Jan 02, 2026 at 02:21:57PM +0530, Harshal Dev wrote: >>> [..] >>>> >>>> >>>> I agree that the defconfig change effectively enables the driver for all arm64 >>>> boards, not just Qualcomm SoC based ones. To clarify this in the commit message, >>>> let me explicitly state the following: >>>> - Why we are enabling it for all arm64 boards. >>>> - From which Qualcomm SoC onwards the driver is applicable to. >>>> - What functionality the driver provides. >>>> - How it's functionality has been tested and on which board. >>>> >>>> " >>>> arm64: defconfig: Enable QCOMTEE module for QTEE-enabled Qualcomm SoCs >>>> >>>> All Qualcomm SoCs starting from SM8650 provide access to the Qualcomm Trusted >>>> Execution Environment (QTEE) through the SMCInvoke interface, implemented by >>>> the QCOMTEE driver. QTEE runs in the Secure World domain on ARM64 CPUs and >>>> exposes secure services to Linux running in the Normal World domain. >>>> >>>> This change enables the QCOMTEE driver as a module to support communication >>>> with QTEE. >>>> >>>> QCOMTEE has been tested on a Qualcomm RB3Gen2 board by loading and executing >>>> a Trusted Application via tests hosted at github.com/qualcomm/minkipc. >>>> " >>> >>> This commit message looks good to me. >>> >>> It also makes it clear that all platforms up to (not including) SM8650 >>> _only_ supports QSEECOM, and hence makes it clear that we have reason to >>> support both mechanisms. >> >> I agree, before QCOMTEE driver, QSEECOM was the only way to communicate with >> QTEE. >> >> I hope everyone else is aligned as well. >> I will send a new patch version with the updated commit. >> > > I said the commit message looks good, not sure why you will send a new > version. > Yes, I understood that Bjorn, I meant to say that I will send a new patch-set version 4 with this updated commit message that you just approved. :) > What I wanted to put in writing is what you're saying - that all targets > prior to SM8650 will only use QSEECOM - something that was contended in > the previous discussions. > I believe this the earlier statement from me that you're referring to, "Based on all this, I am thinking perhaps it would be better to say that the patch enables QCOMTEE driver for Qualcomm SoCs with arm64 CPUs? We could drop mentions of specific SM8x50 models with HDK/MTP boards since the feature is agnostic to those?" I would like to correct this and make it clear. Not all Qualcomm SoCs would work with the QCOMTEE driver. This was also demonstrated by Sumit earlier, when he tried to test the driver on db845c and failed: https://lore.kernel.org/all/aCRkRTMFi65zBODh@sumit-X1/#t This was because the QTEE firmware OS version on older Qualcomm SoCs does not support the SMCInvoke protocol, and so QSEECOM is the only way to talk to QTEE on these platforms. The SCM driver dynamically checks for SMCInvoke protocol support during probe and does not register the 'QCOMTEE' device if it fails to detect that support from QTEE firmware OS side: https://elixir.bootlin.com/linux/v6.18.3/source/drivers/firmware/qcom/qcom_scm.c#L2203 So yes, for targets prior to SM8650, there is no guarantee that QCOMTEE would work for them. Thanks, Harshal > Regards, > Bjorn > >> Thanks, >> Harshal >> >>> >>> Thank you, >>> Bjorn >>