From: <manoj.sharma@wipro.com>
To: <sct@redhat.com>, <akpm@zip.com.au>, <adilger@clusterfs.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.4.31 O_DIRECT support for ext3
Date: Tue, 9 Aug 2005 18:35:29 +0530 [thread overview]
Message-ID: <7352E281DE2FDC4E8F29EC48AAE1668C0910CF@blr-m3-msg.wipro.com> (raw)
Hi,
This is back-port of O_DIRECT support for ext3 from 2.6 to 2.4.31
kernel.
Any suggestions/comments ?
Thanks,
Manoj
--- linux-2.4-latest/fs/ext3/inode.c 2005-08-08 11:46:52.000000000
+0530
+++ linux-2.4.31/fs/ext3/inode.c 2005-08-09 14:59:16.000000000
+0530
@@ -31,6 +31,7 @@
#include <linux/highuid.h>
#include <linux/quotaops.h>
#include <linux/module.h>
+#include <linux/iobuf.h>
/*
* SEARCH_FROM_ZERO forces each block allocation to search from the
start
@@ -1388,6 +1389,68 @@
}
+#define DIO_CREDITS (EXT3_RESERVE_TRANS_BLOCKS + 32)
+
+static int ext3_direct_IO(int rw, struct inode * inode, struct kiobuf *
iobuf, unsigned long blocknr, int blocksize)
+{
+ ssize_t ret;
+ loff_t offset, final_size;
+ handle_t *handle = NULL;
+ int orphan = 0;
+ struct ext3_inode_info *ei = EXT3_I(inode);
+
+ offset = ((loff_t)blocknr) * blocksize;
+ final_size = offset + iobuf->length;
+
+ if (rw == WRITE) {
+
+ handle = ext3_journal_start(inode, DIO_CREDITS);
+ if (IS_ERR(handle)) {
+ ret = PTR_ERR(handle);
+ goto out;
+ }
+ if (final_size > inode->i_size) {
+ ret = ext3_orphan_add(handle, inode);
+ if (ret)
+ goto out_stop;
+ orphan = 1;
+ ei->i_disksize = inode->i_size;
+ }
+ }
+
+ ret = generic_direct_IO(rw, inode, iobuf, blocknr, blocksize,
ext3_get_block);
+
+ handle = journal_current_handle();
+
+out_stop:
+ if (handle) {
+ int err;
+
+ if (orphan && inode->i_nlink)
+ ext3_orphan_del(handle, inode);
+ if (orphan && ret > 0) {
+ loff_t end = offset + ret;
+ if (end > inode->i_size) {
+ ei->i_disksize = end;
+ inode->i_size = end;
+ /*
+ * We're going to return a positive `ret'
+ * here due to non-zero-length I/O, so
there's
+ * no way of reporting error returns from
+ * ext3_mark_inode_dirty() to userspace.
So
+ * ignore it.
+ */
+ ext3_mark_inode_dirty(handle, inode);
+ }
+ }
+ err = ext3_journal_stop(handle, inode);
+ if (ret == 0)
+ ret = err;
+ }
+out:
+ return ret;
+}
+
struct address_space_operations ext3_aops = {
readpage: ext3_readpage, /* BKL not held. Don't
need */
writepage: ext3_writepage, /* BKL not held. We
take it */
@@ -1397,6 +1460,7 @@
bmap: ext3_bmap, /* BKL held */
flushpage: ext3_flushpage, /* BKL not held. Don't
need */
releasepage: ext3_releasepage, /* BKL not held. Don't
need */
+ direct_IO: ext3_direct_IO,
};
/*
next reply other threads:[~2005-08-09 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 13:05 manoj.sharma [this message]
2005-08-09 13:11 ` Arjan van de Ven
2005-08-10 10:50 ` Manoj Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7352E281DE2FDC4E8F29EC48AAE1668C0910CF@blr-m3-msg.wipro.com \
--to=manoj.sharma@wipro.com \
--cc=adilger@clusterfs.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®