From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Lai Jiangshan <jiangshan.ljs@antgroup.com>
Subject: Re: [PATCH v2 5/8] KVM: x86/mmu: Use separate namespaces for guest PTEs and shadow PTEs
Date: Wed, 15 Jun 2022 16:34:35 +0200 [thread overview]
Message-ID: <7355b23b-d1ca-0050-4acf-e4a9a15adffa@redhat.com> (raw)
In-Reply-To: <YqnsAIKxQniAsb1d@google.com>
On 6/15/22 16:26, Sean Christopherson wrote:
>> + * For example, a 4-byte PDE consumes bits 31:22 and an 8-byte PDE
>> + * consumes bits 29:21. Each guest PD must be expanded into four
>> + * shadow PDs, one for each value of bits 31:30, and the PDPEs
>> + * will use the four quadrants in round-robin fashion.
> It's not round-robin, that would imply KVM rotates through each quadrant on its
> own. FWIW, I like David's comment from his patch that simplifies this mess in a
> similar way.
>
> https://lore.kernel.org/all/20220516232138.1783324-5-dmatlack@google.com
Yeah, by round-robin I meant that the 512 entries will look like q=0 q=1
q=2 q=3 q=0 q=1 etc.
I'll incorporate David's comment, minus the last paragraph.
Paolo
next prev parent reply other threads:[~2022-06-15 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 23:33 [PATCH v2 0/8] KVM: x86/mmu: Use separate namespaces gPTEs and SPTEs Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 1/8] KVM: x86/mmu: Drop unused CMPXCHG macro from paging_tmpl.h Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 2/8] KVM: VMX: Refactor 32-bit PSE PT creation to avoid using MMU macro Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 3/8] KVM: x86/mmu: Bury 32-bit PSE paging helpers in paging_tmpl.h Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 4/8] KVM: x86/mmu: Dedup macros for computing various page table masks Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 5/8] KVM: x86/mmu: Use separate namespaces for guest PTEs and shadow PTEs Sean Christopherson
2022-06-15 13:49 ` Paolo Bonzini
2022-06-15 14:01 ` Paolo Bonzini
2022-06-15 14:26 ` Sean Christopherson
2022-06-15 14:34 ` Paolo Bonzini [this message]
2022-06-14 23:33 ` [PATCH v2 6/8] KVM: x86/mmu: Use common macros to compute 32/64-bit paging masks Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 7/8] KVM: x86/mmu: Truncate paging32's PT_BASE_ADDR_MASK to 32 bits Sean Christopherson
2022-06-14 23:33 ` [PATCH v2 8/8] KVM: x86/mmu: Use common logic for computing the 32/64-bit base PA mask Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7355b23b-d1ca-0050-4acf-e4a9a15adffa@redhat.com \
--to=pbonzini@redhat.com \
--cc=jiangshan.ljs@antgroup.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®