From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6E9CDB474 for ; Tue, 17 Oct 2023 06:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234583AbjJQGZ6 (ORCPT ); Tue, 17 Oct 2023 02:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234507AbjJQGZx (ORCPT ); Tue, 17 Oct 2023 02:25:53 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09F6B8F; Mon, 16 Oct 2023 23:25:50 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6F323C0007; Tue, 17 Oct 2023 06:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1697523949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=itnPW5rRfzWD1R0hThVhfk8sAUkui3kg+yDMgRUM000=; b=bcTdqH2iIG9E86n9wjdLB9+H1RfKLhSC1wgDOmxIwvCp3LLgzdRHfsygoJxwnDurJqvOhh ci1qBi8NI2RV5PvEeN2ONy+TIog7sDsPSXcnKN5YYHcrBm4m9REvx7w+VjfEllLn+wKSWQ QjmvEIYNxq3hfgCIDOmQdrYn3RT3WSCU+4rjZcDv7THt/gqvQWjtNNs3dyLBP1vwxlQfAw 6rlU8hfuB2xhGaSGRaCy8lv9kVlm6o7Y/m6ZoRnxy2dGqD1SFRJqwnm90FLarqbAnjqLg+ f74wTcSI+f+fB3yuMX78XBjEUUpgWQr2tgyFDrjskmejyDyL/8VnN1nLEreKeg== Message-ID: <735a683c-fdf2-42ab-b94b-efb32847979d@arinc9.com> Date: Tue, 17 Oct 2023 09:25:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 3/8] dt-bindings: net: dsa/switch: Make 'ethernet-port' node addresses hex Content-Language: en-US To: Rob Herring , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrew Lunn , Florian Fainelli , Vladimir Oltean , Matthias Brugger , AngeloGioacchino Del Regno , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Landen Chao , DENG Qingfang , Sean Wang , Daniel Golle , John Crispin , Gerhard Engleder , Heiner Kallweit , Sergey Shtylyov , Sergei Shtylyov , Justin Chen , Florian Fainelli , Grygorii Strashko , Sekhar Nori , Claudiu Manoil , Alexandre Belloni Cc: Vladimir Oltean , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com References: <20231016-dt-net-cleanups-v1-0-a525a090b444@kernel.org> <20231016-dt-net-cleanups-v1-3-a525a090b444@kernel.org> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20231016-dt-net-cleanups-v1-3-a525a090b444@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.10.2023 00:44, Rob Herring wrote: > 'ethernet-port' node unit-addresses should be in hexadecimal. Some > instances have it correct, but fix the ones that don't. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 2 +- > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 2 +- > Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 6 +++--- > Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml | 2 +- > Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 2 +- > Documentation/devicetree/bindings/net/ethernet-switch.yaml | 4 ++-- > Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml | 2 +- > 7 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml > index aa3162c74833..75d8138298fb 100644 > --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml > +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml > @@ -53,7 +53,7 @@ properties: > const: 0 > > patternProperties: > - "^port@[0-9]+$": > + "^port@[0-9a-f]+$": > type: object > > $ref: ethernet-controller.yaml# > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > index ec74a660beda..e6010821f86f 100644 > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml > @@ -50,7 +50,7 @@ $defs: > const: 0 > > patternProperties: > - "^(ethernet-)?port@[0-9]+$": > + "^(ethernet-)?port@[0-9a-f]+$": > description: Ethernet switch ports > $ref: dsa-port.yaml# > unevaluatedProperties: false > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 20f7ba4e2203..5038818e9f2e 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -157,7 +157,7 @@ patternProperties: > additionalProperties: true > > patternProperties: > - "^(ethernet-)?port@[0-9]+$": > + "^(ethernet-)?port@[0-6]$": You also restrict the pattern depending on how many ports the switch has. Shouldn't this be a separate patch or, at the least, mentioned on the patch log? Regardless: Acked-by: Arınç ÜNAL Arınç