From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shenghao Ding <shenghao-ding@ti.com>,
broonie@kernel.org, conor+dt@kernel.org
Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
kevin-lu@ti.com, baojun.xu@ti.com, devicetree@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml
Date: Thu, 21 Dec 2023 18:31:05 +0100 [thread overview]
Message-ID: <7362295b-4a01-4574-8d96-d10f405eaea0@linaro.org> (raw)
In-Reply-To: <20231221101346.429-1-shenghao-ding@ti.com>
On 21/12/2023 11:13, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in tas2781 to better
> support dsp mode.
Please provide rationale in terms of bindings and hardware, not in terms
of driver. Or at least not only. For example "supported in tas2781" does
not fit hardware part, so you sure must be talking about drivers thus
why driver change would affect bindings?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-21 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:13 Shenghao Ding
2023-12-21 10:13 ` [PATCH v2 2/5] ASoC: tas2562: remove tas2563 into driver Shenghao Ding
2023-12-21 15:52 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 3/5] ASoC: tas2781: Add tas2563 into header file for dsp mode Shenghao Ding
2023-12-21 15:53 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2023-12-21 15:54 ` Andy Shevchenko
2023-12-21 10:13 ` [PATCH v2 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to support dsp mode better Shenghao Ding
2023-12-21 17:29 ` Krzysztof Kozlowski
2023-12-21 15:50 ` [PATCH v2 1/5] ASoC: dt-bindings: remove tas2563 from yaml Andy Shevchenko
2023-12-21 17:31 ` Krzysztof Kozlowski
2023-12-27 7:04 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 10:55 ` Krzysztof Kozlowski
2023-12-23 11:48 ` Ding, Shenghao
2023-12-21 17:31 ` Krzysztof Kozlowski [this message]
2023-12-27 7:07 ` Ding, Shenghao
2023-12-27 10:56 ` Krzysztof Kozlowski
2023-12-27 13:45 ` Ding, Shenghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7362295b-4a01-4574-8d96-d10f405eaea0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®