From: Mukesh R <mrathor@linux.microsoft.com>
To: Magnus Kulke <magnuskulke@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Souradeep Chakrabarti <schakrabarti@microsoft.com>,
Wei Liu <liuwe@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Magnus Kulke <magnuskulke@microsoft.com>,
Long Li <longli@microsoft.com>,
linux-arch@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Anirudh Rayabharam <Anirudh.Rayabharam@microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH v3] drivers/hv: remove deposited pages from direct map
Date: Thu, 24 Sep 2026 17:30:02 -0700 [thread overview]
Message-ID: <7363cfd4-31f0-451f-0cf5-879e878b30ef@linux.microsoft.com> (raw)
In-Reply-To: <aq0W/c9SKCympVHE@example.com>
On 9/18/26 03:48, Magnus Kulke wrote:
> On Thu, Sep 17, 2026 at 05:23:15PM -0700, Mukesh R wrote:
>> On 9/17/26 13:10, Magnus Kulke wrote:
>>
>> FYI:
>>
>> https://lore.kernel.org/linux-hyperv/20260912000318.2959621-1-mrathor@linux.microsoft.com/
>>
>> Thanks,
>> -Mukesh
>>
>>
>
> Thanks, the change to a larger single page makes sense. I assume we
> would still be susceptible to a #GP once the kernel steps into it?
>
> Since this is addressing acute crashes on L1VH, it would be good to
> merge a fix first IMO. it can then be easily cherrypicked into
> backports or distro-kernels.
>
> Or would you rather see the problem addressed as part of in your
> deposit-pages refactoring?
no, we need to backport deposit-pages also (it is already in the
internal 6.18) as not only it enhances the deposit, but also fixes
couple bugs, so best to keep this separate. the deposit patch does
address your comment:
+ HV_DEPOSIT_MAX is capped at 511, so a deposit range cannot cover
+ * a 2MiB page, so deposited pages are of 4k granularity and cannot
+ * be collapses into a 2MiB page, which would require an allocation
+ * and can potentially fail.
IOW, as soon as it's merged, above will not be true always.
Thanks,
-Mukesh
> best,
>
> magnus
next prev parent reply other threads:[~2026-09-25 0:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 20:10 Magnus Kulke
2026-09-18 0:23 ` Mukesh R
2026-09-18 10:48 ` Magnus Kulke
2026-09-19 23:16 ` Wei Liu
2026-09-25 0:30 ` Mukesh R [this message]
2026-09-25 12:01 ` Magnus Kulke
2026-09-19 23:30 ` Wei Liu
2026-09-24 13:51 ` Anirudh Rayabharam
2026-09-25 11:57 ` Magnus Kulke
2026-09-25 16:23 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7363cfd4-31f0-451f-0cf5-879e878b30ef@linux.microsoft.com \
--to=mrathor@linux.microsoft.com \
--cc=Anirudh.Rayabharam@microsoft.com \
--cc=arnd@arndb.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=longli@microsoft.com \
--cc=magnuskulke@linux.microsoft.com \
--cc=magnuskulke@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=schakrabarti@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®