mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: fw@strlen.de, coreteam@netfilter.org, davem@davemloft.net,
	edumazet@google.com, horms@kernel.org, kadlec@netfilter.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, pabeni@redhat.com,
	zi.li@linux.dev
Subject: Re: [PATCH v3 1/1] netfilter: load nf_log_syslog on enabling nf_conntrack_log_invalid
Date: Tue, 29 Jul 2025 09:52:32 +0800	[thread overview]
Message-ID: <73710fd4-de44-459f-8db0-02e493566691@linux.dev> (raw)
In-Reply-To: <aIgb64Riu6FBcC28@calendula>



On 2025/7/29 08:55, Pablo Neira Ayuso wrote:
> On Mon, Jul 28, 2025 at 06:25:14PM +0800, Lance Yang wrote:
>> From: Lance Yang <lance.yang@linux.dev>
>>
>> When no logger is registered, nf_conntrack_log_invalid fails to log invalid
>> packets, leaving users unaware of actual invalid traffic. Improve this by
>> loading nf_log_syslog, similar to how 'iptables -I FORWARD 1 -m conntrack
>> --ctstate INVALID -j LOG' triggers it.
> 
> JFYI: I ended up taking v2 into nf-next, let me know if there is any
> issue with your previous version, thanks.

Thanks for picking up v2 and merging it into nf-next!

No issues at all from my side. v3 only contains minor cleanups with
no functional changes, so v2 is fine and good to go ;)

Thanks,
Lance


      reply	other threads:[~2025-07-29  1:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 10:25 Lance Yang
2025-07-29  0:55 ` Pablo Neira Ayuso
2025-07-29  1:52   ` Lance Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73710fd4-de44-459f-8db0-02e493566691@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=zi.li@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®