From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C9052874E1 for ; Fri, 6 Jun 2025 11:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749210771; cv=none; b=K9kD2qN3SOI64Af0m4FtJ3EpmBbzECCTIsxiZphCOpcd9pvWmhp4o4/hHLYCFQTfxtpec1T09zvEgmZvzfq/ozVmE7bp/5/bH+J/Hg8qL7Q1+6fYQDTCtBJ3ymNWGKB55FswN52WMokocjf2fRjohKOftRuaGGnhJt2GABMavWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749210771; c=relaxed/simple; bh=NMi3bOMFzSpf51wIBgElg5vr2yGTA7xWJIt8f+igTtY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MjFgBJWVUv1BUjap2m1y5douFAQ+TcsgK9VQ+6y9WHiOyKuaeY/aG+5tKYLxhKNyS2h56+qX7HJRpso8Gcjrsu9yz7LBvvTR57eqK1xx0gGfHm3BIr0EO0atns/BPg0zg3Fma7UDh9QwuhRfIfjb7hw3i+q4MD6xwFy7Gyk9qsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=al+zkC5X; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="al+zkC5X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749210769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=z+FEbX3L9HmrbUYpED1MkPniL68fqNN+10/AKObI0A4=; b=al+zkC5XnDfL1ZU6sHKVqI8u7GVNWNZsHXGl3sma/YR3qZUlBMmXYb7zS3Wn6PAFJXzuV7 7oWW9RcykuZeuTftzzRyzdxZwXmqXTZwMxgipOHz1EmZSh0AxO79cb1vMQszlFmodMO79p tLCacHQ7oKUAti+qfqDoh0UeQHWIAMc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-gizkj0TCO0e5MMhS8DyuZQ-1; Fri, 06 Jun 2025 07:52:48 -0400 X-MC-Unique: gizkj0TCO0e5MMhS8DyuZQ-1 X-Mimecast-MFC-AGG-ID: gizkj0TCO0e5MMhS8DyuZQ_1749210767 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d9f96f61so14335725e9.1 for ; Fri, 06 Jun 2025 04:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749210767; x=1749815567; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z+FEbX3L9HmrbUYpED1MkPniL68fqNN+10/AKObI0A4=; b=xGzD9JLC2RebagHHabTSiEaNzoLMZsewfCfsLfWcG/xmXSvbVpSLR8W9M1McelHK/e 4/PL9UefGrEkxukaZbV1HM7pde38mkIsbdpnrMzZJtGi5WDa6IXo/gDODt3xlOnx58Hj a8nQBEbuHvSbjphTo4yeqnP0EFO566X80cA55FZdzV1U3RBKvWXXiGcGnBjHB0v6JRzG 7gpLTQodoKD3SIjm9L4jhkp4QbR5VEXhkkBVgDds6lT7f6HE3GgM13HQsISAM5vGCeIX NCVC/6GDbpxxeWy1Lmend/3Jp8Ua/2ZV8i3g7vmL4zgisOPgp7xgtZSHyDSnBJ21HXEJ Z1uA== X-Forwarded-Encrypted: i=1; AJvYcCX0PERK2jP8zwxgGF9QB7m7zYsDVtnRUVL5DWkG/C4W6qgm3u6gR4Q50Fjvnrx0IQ18ktkXbnwetEbhQjw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2BgvevkOCEJ0lHY1g4xZ3tWMa2/VTHW5YoVKv+JuZ+dCqbAKA UMU4mczM3dpLdRpmRzYx7/cwSEMWItM4WdGBBz7SZ4ed0AoEMCyq/ZC1fFQ7fPKmn/nk6PLYOub BYMMJ0riKQtz0mAs/5C+36yLGs5rRuDBT+UdiMjzO/9dPvt4ZWX7EiHi3daqRm9ZmKA== X-Gm-Gg: ASbGncvV9lTpPsWiV36u3bm03lWReKRsH5R0j1lSLijtb0JiO9iz9oafn7hcBEZg1Ea oN9DWjG5r5ixtnDwY7TvwLcTe9ISJBQtnTL6R7Mxr5uIhKNaz8vBMKqumIv6gXxsrhcUoM6nTbj ptk2KJqx0c3VJT7V6LICcbfeFP3DIOn/9//wp1hoK1lbSwTruiHwhax07hQKS8DiF99vpNcGXwk X/YBzWEvYcWkdCzv6y4iarCMPKa3bXbv55omVe8vxLvKnCEi3XlFgEG1w5aDGYAH1s/sS2wN7To F2H4iKe6ScqvsdelO5Fk6La0X4/uy4jVhYqqQfS6tpp4tCQEEYlzR+cwYmwbnMjMJ3kr4YGGXZd 5aBcAULX0Rx2NifK/nnVMBsuRTNmhbuc= X-Received: by 2002:a05:600c:4e0a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4520143085emr30492575e9.33.1749210766853; Fri, 06 Jun 2025 04:52:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGebp748ZUJlgbYSDwhtX4XrCnpmqEcIzPAJIqqCkpY9vlhyhbH+iXq1p9Qo3rMj0g75gatzg== X-Received: by 2002:a05:600c:4e0a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4520143085emr30492375e9.33.1749210766490; Fri, 06 Jun 2025 04:52:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53243664fsm1675690f8f.65.2025.06.06.04.52.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 04:52:46 -0700 (PDT) Message-ID: <7375c9c2-42f4-4c90-ba16-a365857d91d0@redhat.com> Date: Fri, 6 Jun 2025 13:52:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 08/10] kernel,cpuset: Use node-notifier instead of memory-notifier To: Oscar Salvador , Andrew Morton Cc: Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250605142305.244465-1-osalvador@suse.de> <20250605142305.244465-9-osalvador@suse.de> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605142305.244465-9-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.06.25 16:22, Oscar Salvador wrote: > cpuset is only concerned when a numa node changes its memory state, > as it needs to know the current numa nodes with memory to keep > an updated mems_allowed mask. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > kernel/cgroup/cpuset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 83639a12883d..66c84024f217 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -4013,7 +4013,7 @@ void __init cpuset_init_smp(void) > cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask); > top_cpuset.effective_mems = node_states[N_MEMORY]; > > - hotplug_memory_notifier(cpuset_track_online_nodes, CPUSET_CALLBACK_PRI); > + hotplug_node_notifier(cpuset_track_online_nodes, CPUSET_CALLBACK_PRI); Interestingly, cpuset_track_online_nodes() is only concerned about "after node_states[N_MEMORY] change", so maybe we could filter out more events .. maybe. Acked-by: David Hildenbrand -- Cheers, David / dhildenb