From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C575C433E6 for ; Tue, 5 Jan 2021 17:03:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00BFA22CF6 for ; Tue, 5 Jan 2021 17:03:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730487AbhAERDW (ORCPT ); Tue, 5 Jan 2021 12:03:22 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:18182 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729248AbhAERDV (ORCPT ); Tue, 5 Jan 2021 12:03:21 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 105H2UXi010184; Tue, 5 Jan 2021 18:02:31 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=o/tvGSRFaT8cAu8YixqpGXymFM5L4ZlyvrozxyJlsZ0=; b=nmPgg4FEunCGfFO2mSiDimZ0mEPqN4XoiS8/yyVOskxYQlaA8h6vz+C8y3ODq4L85cTj XlL/pRFtwhOf9l1SDMkYwFrsJrMabL3wZwDNAj5v5BoLjW0L1/xMYkTMb6y8tIgsC5hB CbG1e5s1VQN+jbIT8NsJvb1qV7yUdSVa5PI7oKWzZ4F8VZYdqkG5z2AzJB5Kr4Tw456M mcvi+xZQkm6rHVike3WqjbQZiAlus9g+sW3ruH1RdNz17bCnu8sx+DpbvwSACcUVTUNV tHJuEvtqgM3L0YxpDxpYwAeb3Cehri4ddqm8FQM/HOxw670ISVS8ZQaVBrJbHpFZP5dP aw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 35teuv2ejj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Jan 2021 18:02:31 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BA98B10003E; Tue, 5 Jan 2021 18:02:29 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id AA37E22BFCE; Tue, 5 Jan 2021 18:02:29 +0100 (CET) Received: from lmecxl0889.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 5 Jan 2021 18:02:29 +0100 Subject: Re: [PATCH v2 05/16] rpmsg: ns: initialize channel info override field To: Bjorn Andersson CC: Ohad Ben-Cohen , Mathieu Poirier , Andy Gross , , , , References: <20201222105726.16906-1-arnaud.pouliquen@foss.st.com> <20201222105726.16906-6-arnaud.pouliquen@foss.st.com> From: Arnaud POULIQUEN Message-ID: <7375f9ef-7179-8ec1-3133-4519d4f68c3a@foss.st.com> Date: Tue, 5 Jan 2021 18:02:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-05_05:2021-01-05,2021-01-05 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/21 1:38 AM, Bjorn Andersson wrote: > On Tue 22 Dec 04:57 CST 2020, Arnaud Pouliquen wrote: > >> By default driver_override should be 0 to avoid to force >> the channel creation with a specified name.The local variable >> is not initialized. >> > > The same problem exists in qcom_glink_native, qcom_smd and rpmsg_char. Right! And perhaps initializing the structure on declaration would be a better method. Thanks, Arnaud > > Regards, > Bjorn > >> Signed-off-by: Arnaud Pouliquen >> --- >> drivers/rpmsg/rpmsg_ns.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c >> index 762ff1ae279f..a526bff62947 100644 >> --- a/drivers/rpmsg/rpmsg_ns.c >> +++ b/drivers/rpmsg/rpmsg_ns.c >> @@ -55,6 +55,7 @@ static int rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, >> strncpy(chinfo.name, msg->name, sizeof(chinfo.name)); >> chinfo.src = RPMSG_ADDR_ANY; >> chinfo.dst = rpmsg32_to_cpu(rpdev, msg->addr); >> + chinfo.driver_override = NULL; >> >> dev_info(dev, "%sing channel %s addr 0x%x\n", >> rpmsg32_to_cpu(rpdev, msg->flags) & RPMSG_NS_DESTROY ? >> -- >> 2.17.1 >>