From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752723AbdKEJeT (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Nov 2017 04:34:19 -0500
Received: from mout.web.de ([212.227.15.4]:49839 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752660AbdKEJeQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Nov 2017 04:34:16 -0500
Subject: Re: USB: core: Improve unlocking of a mutex in two functions
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Eugene Korenevsky <ekorenevsky@gmail.com>,
        =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= <linux@roeck-us.net>,
        Jaejoong Kim <climbbb.kim@gmail.com>, Johan Hovold <johan@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <0ff5f74e-ae23-5c97-8998-0e598ceae96b@users.sourceforge.net>
 <CAMuHMdUXn4YVPBFCoqmwcdU7eTWO5jy2ZXZQaAxPi1P5bM4q2A@mail.gmail.com>
 <20171105073013.GA1431@kroah.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <73765f7c-57b6-9ade-bca3-4d65b30f2d5d@users.sourceforge.net>
Date: Sun, 5 Nov 2017 10:33:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171105073013.GA1431@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:Aw1Av4GOJJCNPPYT3gJT9K4oKqAC9h+UTKe9E4ZzODK1PX2E8A9
 B2jlsiUhXMY6MuJ9Ynqf59AYPq+Sp4U8H17WdlceHgnD7DUgJ4VJpsNSkc2JFmS89b3LCYM
 DfFn/gk1cWdNfV4q6sViXaZfhM/X2ojaLJHIri1TH/g7Bb4Ww7uT7pAJm7jh1d6V5ze7YFq
 rRe7/Pa0UfmDhxGfuDMZQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:COUCpuFl9MQ=:8WsC+fqAOwPSU7f9BKdO7y
 /KtaCZO/A2bpPwTnmmKpmf+1FvdHwfvJ79nFnK1t4nn98Q5rxust6TSFvvqp0sutajlGaFlEI
 kdHf5KG497AxSUkTr/g2sW0gjo5cmdPJ2uIgp2yd3SVzr4A2cgrKcmRXl/pdlJvcG582cFrx0
 k9EPZy6jD/qe5ZAyVcQfblFiI+/7sdEbG4RBBf6PAal9YiOu4tBZpzd7uHjJPMtb6bJGAZ+4d
 Yqd/jYbVIz3kKGxxL+0dn6IaphauuE3cz6+OHyCqluFLJAWRG36sAvN2KE+yWOq0xsk1U+Yt0
 EqTaV06wCpZbRitf8tXZhO2v3cNgDSWeEpoQj3gW6j3AvtBKp3MoymmrgnxY3ugw4SyUpzP97
 8tKY3LAx1ZFhwZbDh2RieidCgYV9KajC/irJWriTWS6lhTgR4HSEZ0gIpbAWZwbffv4oSdADn
 iX3yUv9l+w9LGG9pOBpuVD+EhKZV3rkjavB92cJSI6vUny08H5Jl4W9AqRF71b8ndcoi6X5l6
 2JkwyrRd1doWTrNYv6OQ71m+TVCbFOGocIzCcFGHn7wiN22KFmFv3NdZ1AOOoDX8hLV6hDRrf
 6tl/gdg4K2y9ariRr6ogZigMxVtq7xaDIPv62FQdOXhtTpAe2r7jjsnK/pU5TGLeS8wmnjkA5
 tvM+EhgKPSVUgG4RXQ1T1AA3QaNmt08dy8jHfrXRh1ZkKfKcrI26ZFz+bKPlYtWEAQXOhKAFL
 0tNCapDtiLTvYhfVtIMqzkBjasjd8V9pTNqDMdO3fnw4UCWOzQtgiXAtg4hYst1mkO1jnfi+1
 c9xbnkoyPykwuLVtBREjHufvMQ5Z4n0EeZCE3S6Exa12tyVc8I=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Don't worry, or waste your time, I don't take patches from this author
> as they are in my blacklist.

I am curious if our dialogue can become more constructive again. 🌈


I can offer another bit of information for this software development discussion. 💭

The affected source files can be compiled for the processor architecture “x86_64”
by a tool like “GCC 6.4.1+r251631-1.3” from the software distribution
“openSUSE Tumbleweed” with the following command example.

my_cc=/usr/bin/gcc-6 \
&& my_module1=drivers/usb/core/hub.o \
&& my_module2=drivers/usb/core/message.o \
&& git checkout next-20171102 \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module1}" "${my_module2}" \
&& size "${my_module1}" "${my_module2}" \
&& git checkout ':/^USB: core: Improve unlocking of a mutex in two functions' \
&& make -j4 CC="${my_cc}" HOSTCC="${my_cc}" allmodconfig "${my_module1}" "${my_module2}" \
&& size "${my_module1}" "${my_module2}"


🔮 Do you find the following differences useful for further clarification?

╔═════════╤══════╗
║ module  │ text ║
╠═════════╪══════╣
║ hub     │ -16  ║
║ message │ -48  ║
╚═════════╧══════╝


Regards,
Markus