From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] ARM: tegra: Remove cpuidle drivers
Date: Fri, 12 Jul 2019 10:39:46 +0100 [thread overview]
Message-ID: <73781434-d25a-b17b-aacb-95ace5ac5f95@nvidia.com> (raw)
In-Reply-To: <a6e4b43e-369c-c501-6d2e-69d5b940ff9c@gmail.com>
On 11/07/2019 18:03, Dmitry Osipenko wrote:
> 11.07.2019 12:26, Jon Hunter пишет:
>>
>> On 11/07/2019 04:13, Dmitry Osipenko wrote:
>>> Remove the old drivers to replace them cleanly with a new one later on.
>>>
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
>>> arch/arm/mach-tegra/Makefile | 13 --
>>> arch/arm/mach-tegra/cpuidle-tegra114.c | 89 -----------
>>> arch/arm/mach-tegra/cpuidle-tegra20.c | 212 -------------------------
>>> arch/arm/mach-tegra/cpuidle-tegra30.c | 132 ---------------
>>> arch/arm/mach-tegra/cpuidle.c | 50 ------
>>> arch/arm/mach-tegra/cpuidle.h | 21 ---
>>> arch/arm/mach-tegra/irq.c | 18 ---
>>> arch/arm/mach-tegra/irq.h | 11 --
>>> arch/arm/mach-tegra/pm.c | 7 -
>>> arch/arm/mach-tegra/pm.h | 1 -
>>> arch/arm/mach-tegra/reset-handler.S | 11 --
>>> arch/arm/mach-tegra/reset.h | 9 +-
>>> arch/arm/mach-tegra/sleep-tegra20.S | 190 +---------------------
>>> arch/arm/mach-tegra/sleep.h | 12 --
>>> arch/arm/mach-tegra/tegra.c | 3 -
>>> drivers/soc/tegra/Kconfig | 1 -
>>> include/soc/tegra/cpuidle.h | 4 -
>>> 17 files changed, 5 insertions(+), 779 deletions(-)
>>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra114.c
>>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra20.c
>>> delete mode 100644 arch/arm/mach-tegra/cpuidle-tegra30.c
>>> delete mode 100644 arch/arm/mach-tegra/cpuidle.c
>>> delete mode 100644 arch/arm/mach-tegra/cpuidle.h
>>> delete mode 100644 arch/arm/mach-tegra/irq.h
>>
>> By removing all the above, it is really hard to review the diff. Is
>> there any way you could first consolidate the cpuidle drivers into say
>> the existing arch/arm/mach-tegra/cpuidle-tegra20.c and then move to
>> drivers/cpuidle?
>
> I'm afraid that it will make reviewing even more difficult because
> everything that is removed here is not returned in the further patches.
> The new driver is based on the older ones, but I wrote it from scratch
> and it's not only looks different, but also works a bit different as you
> may see.
>
> Could you please clarify what exactly makes it hard to review? The diff
> looks pretty clean to me, while squashing everything into existing
> driver should be quite a mess.
Ideally a patch should standalone and can be reviewed by itself.
However, to review this, we need to review patches 1, 2 and 3 at the
same time. So IMO it is not that convenient from a reviewers
perspective. Furthermore, patches 1 and 3 are large and so easy to miss
something.
Is there really no way to have a patch to combined the existing drivers,
then a patch to convert them into the newer rewritten version you have
implemented, then move the driver?
Jon
--
nvpublic
next prev parent reply other threads:[~2019-07-12 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 3:13 [PATCH v2 0/6] Consolidate and improve NVIDIA Tegra CPUIDLE driver(s) Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 1/6] ARM: tegra: Remove cpuidle drivers Dmitry Osipenko
2019-07-11 9:26 ` Jon Hunter
2019-07-11 17:03 ` Dmitry Osipenko
2019-07-12 9:39 ` Jon Hunter [this message]
2019-07-12 16:23 ` Dmitry Osipenko
2019-07-14 22:19 ` Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 2/6] ARM: tegra: Expose functions required for cpuidle driver Dmitry Osipenko
2019-07-11 12:42 ` Jon Hunter
2019-07-11 17:25 ` Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 3/6] cpuidle: Add unified driver for NVIDIA Tegra SoCs Dmitry Osipenko
2019-07-11 18:35 ` Dmitry Osipenko
2019-07-12 16:41 ` Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 4/6] cpuidle: tegra: Support CPU cluster power-down on Tegra30 Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 5/6] ARM: multi_v7_defconfig: Enable Tegra cpuidle driver Dmitry Osipenko
2019-07-11 3:13 ` [PATCH v2 6/6] ARM: tegra: Enable Tegra cpuidle driver in tegra_defconfig Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73781434-d25a-b17b-aacb-95ace5ac5f95@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®