From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758267AbdJMN4V (ORCPT ); Fri, 13 Oct 2017 09:56:21 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:45270 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447AbdJMN4T (ORCPT ); Fri, 13 Oct 2017 09:56:19 -0400 X-Google-Smtp-Source: AOwi7QA1O7K0c0EKV4f0rLEqaDjli6/nooHu79oeF8jp8iolX4QZejz28pOh3u46N99nGpXKTBUwhw== Subject: Re: [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones To: Chunfeng Yun , Mathias Nyman , Greg Kroah-Hartman , Felipe Balbi , Rob Herring Cc: Mark Rutland , Ian Campbell , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <994382d16d6bdc0f3d7c11b22f1710252e056e34.1507882470.git.chunfeng.yun@mediatek.com> <6a5d01f35d7df6a49d0442c8326c3daa9bcda9d3.1507882470.git.chunfeng.yun@mediatek.com> From: Matthias Brugger Message-ID: <7378e644-a44d-d83f-44a4-64b0e7c00e2e@gmail.com> Date: Fri, 13 Oct 2017 15:56:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6a5d01f35d7df6a49d0442c8326c3daa9bcda9d3.1507882470.git.chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2017 10:26 AM, Chunfeng Yun wrote: > Remove dummy clocks for usb wakeup and add optional ones for > MCU_BUS_CK and DMA_BUS_CK. > > Signed-off-by: Chunfeng Yun > Acked-by: Rob Herring > --- Reviewed-by: > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > index 2d9b459..3059596 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > @@ -26,10 +26,11 @@ Required properties: > - clocks : a list of phandle + clock-specifier pairs, one for each > entry in clock-names > - clock-names : must contain > - "sys_ck": for clock of xHCI MAC > - "ref_ck": for reference clock of xHCI MAC > - "wakeup_deb_p0": for USB wakeup debounce clock of port0 > - "wakeup_deb_p1": for USB wakeup debounce clock of port1 > + "sys_ck": controller clock used by normal mode, > + the following ones are optional: > + "ref_ck": reference clock used by low power mode etc, > + "mcu_ck": mcu_bus clock for register access, > + "dma_ck": dma_bus clock for data transfer by DMA > > - phys : a list of phandle + phy specifier pairs > > @@ -57,9 +58,7 @@ usb30: usb@11270000 { > clocks = <&topckgen CLK_TOP_USB30_SEL>, <&clk26m>, > <&pericfg CLK_PERI_USB0>, > <&pericfg CLK_PERI_USB1>; > - clock-names = "sys_ck", "ref_ck", > - "wakeup_deb_p0", > - "wakeup_deb_p1"; > + clock-names = "sys_ck", "ref_ck"; > phys = <&phy_port0 PHY_TYPE_USB3>, > <&phy_port1 PHY_TYPE_USB2>; > vusb33-supply = <&mt6397_vusb_reg>; > @@ -91,9 +90,8 @@ Required properties: > > - clocks : a list of phandle + clock-specifier pairs, one for each > entry in clock-names > - - clock-names : must be > - "sys_ck": for clock of xHCI MAC > - "ref_ck": for reference clock of xHCI MAC > + - clock-names : must contain "sys_ck", and the following ones are optional: > + "ref_ck", "mcu_ck" and "dma_ck" > > Optional properties: > - vbus-supply : reference to the VBUS regulator; >