From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F65E34886F for ; Wed, 7 Jan 2026 15:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798306; cv=none; b=bb6p034NWAG/ZiCLCglE0jGOWKhCPf9yiLlTJj1xx09zNBTntFl9D4EW3KNR+TNZ4dnMkF1a6X0Q1h/gZFAMZa8Rs71EWuZDFhwJwO7J/3VN/ee/+oex9MubeIdwDqZgbK7uKOpe8YDqVtAGbcsoztjtjxB97clKa07ZAsfHK90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767798306; c=relaxed/simple; bh=D5FmglVvkl3g4DuAXZKkWi0EAt1o7Pm+KQPATu7ybOQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=OkpMBuBQSkxCfaDmXahEMsiXU9nTZBxpEUFKc4UGML2+MQI9B0brwOYDJ78fkYZ5Uqr56urm2LAm5bQm0BhENnaEU2kLxNrtmZxfeyDnTvu2mexIxw4W9uLbT4e4WRzLmkxnawqaqHfTTJjgrc0G4aHmyUa5FHpjERXUEglA57M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CtEISEka; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CtEISEka" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4775895d69cso10824055e9.0 for ; Wed, 07 Jan 2026 07:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1767798302; x=1768403102; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=UZ/7ZMF+GZy1qUkEJEGh+CeH3UAPpaGuj74Mgzc+UGQ=; b=CtEISEkaNSereDkNgutOh7W4rCw22UG1W2ZcLdcb+1OL/hlRe6fvz0JvcsMBNtYvm+ KPVuHN4H7/k9KzsHNuRnBGTrghn9pU3oCdqZADXMgU1im8/fZrpk0UFX7SIoieFQ2DfP kRUnUZqTRe9TAbtN7v804XNFsbTJl8crfBpzhC5Uw9R79Oe+RLqISte6UiuG3sWDqBC7 WZV9lQ/oQb6vNgypSZbrQDWeeYWLauKuj1Uisv0c0bznKx9/3SAxl7VXf4zl3gbtlCOG pMxHfaUZNckxIWJJ4aMf6xG0V+4jP+zZv2ssCvrGpjFoC/dR088k2aMezSPFbT2QzDhA 93kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767798302; x=1768403102; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UZ/7ZMF+GZy1qUkEJEGh+CeH3UAPpaGuj74Mgzc+UGQ=; b=T2WuAgGadfQMX1qAz4BdZwq+xztDTQhXNMIMLQiIvTP5oismZ3YDP2Iu8DDb+RXkjs Bd8XlpH+HvRFyCezrgvf6i8hKwx/BxVCe9chUA/w1ijO7YQGgqkVRUQcdQxgWiFm6uZO H/E4Lp9ncCZmK7+ItXSt7zE9nK5dUwNrmqkseiPM5gPCI0ykMNzQPKHTlEe2z4qgBG14 yjMPlRwnDAu9kBvj0DN2lBDRakJSgkcx7TcGhzw7w9qx8L1sY+tghYv90f5fer0KMGMd CJm6Uk2a0lLM1keiu8cKn1dUNGnivzS29RJSmHcNGZaSI6vjR0AA12BpiT3RfREdkJe1 w3LA== X-Forwarded-Encrypted: i=1; AJvYcCXWXiWaYnMUJ6Rv73Mm0IsG1P+yKYmwQbqZfNWBdCugqcGcVlJoWKLXbM7nX3Uvn2YPtilwrFY15jTuc8Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzjDxPTY9dcBf6vyjhLjjSfjx4TehkoLE8igGpLN5bvaMfxpofF 1vwekJSK1F4sJySb7ScC/mkSQyTz+ECfc4wckjonCuBaCMRgErbRMumc3ZARtmMrBYs= X-Gm-Gg: AY/fxX5sAF7mCNLrW2mOnzC8Lu58nZnhU/n9tJWwDtnvTVXIkEib+c9Z8Kf0suL7Xgb Qcp7LWEt2aiiWTva3GXCbNOM8ffRCBtVcIqLRpkFq7vWSqHVLQxsLd9awaFg4pxdrstHq4LjDLK kf9Nm5AUn69hi7yM9lXPidfGd8vQ+pXb5CcXVs+atSk9+XPPos2oBeMLww7CyDLj98AF8FvfFFL 6thnigRBXcQgv0lxBXTDgNNEbppRS3gklDuqqUzJnwOL74BUaxNono3IEU+1lqc/7+jLet/clUH 5cp31AFpf8fYVRZqkrrJkfX0dC/yjleWKpeKbi/YznGC6GS/xBcJu0ITDTB8z3pmQKEjUSmBnYF wdLZLC8vxEfyWD7Efdrm0oBzQ0esfwJ/rt2E+MSvryVwIiyCy7oP9xv/I7REeDUA445BsHOL2PM 4IVoOUapNXPhzz5ucpl2Yr/N6q22D3CJ+HXPly X-Google-Smtp-Source: AGHT+IEOYlyKev/JXhO6ZFSHDXlM8eUuok0NFZfe0rNvo/VSyQSXG3Dl2jreomEhLjqpb0WuT9HVpw== X-Received: by 2002:a05:600c:3110:b0:47d:3ffa:980e with SMTP id 5b1f17b1804b1-47d84b4101dmr28129435e9.28.1767798302280; Wed, 07 Jan 2026 07:05:02 -0800 (PST) Received: from [192.168.3.33] (9.39.160.45.gramnet.com.br. [45.160.39.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee24esm10984075f8f.33.2026.01.07.07.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:05:01 -0800 (PST) Message-ID: <737d6c96a51b5975c9fd7ed302df014e0d5e4fe1.camel@suse.com> Subject: Re: [PATCH net-next 2/2] netconsole: convert to NBCON console infrastructure From: Marcos Paulo de Souza To: Breno Leitao Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asantostc@gmail.com, efault@gmx.de, gustavold@gmail.com, calvin@wbinvd.org, jv@jvosburgh.net, kernel-team@meta.com Date: Wed, 07 Jan 2026 12:04:55 -0300 In-Reply-To: References: <20251222-nbcon-v1-2-65b43c098708@debian.org> <20260102035415.4094835-1-mpdesouza@suse.com> Autocrypt: addr=mpdesouza@suse.com; prefer-encrypt=mutual; keydata=mDMEZ/0YqhYJKwYBBAHaRw8BAQdA4JZz0FED+JD5eKlhkNyjDrp6lAGmgR3LPTduPYGPT Km0Kk1hcmNvcyBQYXVsbyBkZSBTb3V6YSA8bXBkZXNvdXphQHN1c2UuY29tPoiTBBMWCgA7FiEE2g gC66iLbhUsCBoBemssEuRpLLUFAmf9GKoCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk QemssEuRpLLWGxwD/S1I0bjp462FlKb81DikrOfWbeJ0FOJP44eRzmn20HmEBALBZIMrfIH2dJ5eM GO8seNG8sYiP6JfRjl7Hyqca6YsE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-01-06 at 07:43 -0800, Breno Leitao wrote: > Hello Marcos, >=20 > On Fri, Jan 02, 2026 at 12:54:14AM -0300, Marcos Paulo de Souza > wrote: > > On Mon, 22 Dec 2025 06:52:11 -0800 Breno Leitao > > wrote: > > > + if (!nbcon_enter_unsafe(wctxt)) > > > + continue; > >=20 > > In this case, I believe that it should return directly? If it can't > > enter in the > > unsafe region the output buffer is not reliable anymore, so > > retrying the send > > the buffer to a different target isn't correct anymore. Petr, John, > > do you > > agree? >=20 > That makes sense. I undersatnd that the ownership will not be > re-acquired here by just looping through the netconsole targets, > right? Yes, take a look into the drivers/tty/serial/*, some of the only reacquire the context to reset some hardware registers, since the printing context was lost. In this case, for you, I don't believe that you can't continue trying to send data to other targets, since the original data is gone. In any case, the context reacquire method is nbcon_reacquire_nobuf.