From: Chao Yu <chao@kernel.org>
To: Seongjae Jeong <jsjlee1020@gmail.com>, jaegeuk@kernel.org
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix termination of f2fs_sync_meta_caches()
Date: Sun, 11 Oct 2026 18:37:35 +0800 [thread overview]
Message-ID: <73918f53-cf62-4a0f-a28f-a34dfd7de2de@kernel.org> (raw)
In-Reply-To: <20261010074912.114840-1-jsjlee1020@gmail.com>
On 10/10/26 15:49, Seongjae Jeong wrote:
> When __f2fs_write_meta_cache() returns false in f2fs_sync_meta_caches(),
> the function only exits the inner loop instead of the entire
> while loop. This leads to an unnecessary lookup of the next batch.
>
> Also, when nwritten >= nr_to_write, only the inner loop terminates.
> This allows the function to continue processing subsequent batches
> after the writeback budget has been reached.
>
> Terminate the entire while loop in both cases to avoid unnecessary
> batch lookups and respect the writeback budget.
>
> Signed-off-by: Seongjae Jeong <jsjlee1020@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2026-10-11 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 7:49 Seongjae Jeong
2026-10-11 10:37 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73918f53-cf62-4a0f-a28f-a34dfd7de2de@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=jsjlee1020@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®