From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbcHKJxX (ORCPT ); Thu, 11 Aug 2016 05:53:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:43257 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbcHKJxV (ORCPT ); Thu, 11 Aug 2016 05:53:21 -0400 Subject: Re: [PATCH 2/5] mm/debug_pagealloc: don't allocate page_ext if we don't use guard page To: js1304@gmail.com, Andrew Morton References: <1470809784-11516-1-git-send-email-iamjoonsoo.kim@lge.com> <1470809784-11516-3-git-send-email-iamjoonsoo.kim@lge.com> Cc: Minchan Kim , Michal Hocko , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joonsoo Kim From: Vlastimil Babka Message-ID: <7391d520-0512-231b-ef2d-600ab22bda5b@suse.cz> Date: Thu, 11 Aug 2016 11:53:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <1470809784-11516-3-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2016 08:16 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > What debug_pagealloc does is just mapping/unmapping page table. > Basically, it doesn't need additional memory space to memorize something. > But, with guard page feature, it requires additional memory to distinguish > if the page is for guard or not. Guard page is only used when > debug_guardpage_minorder is non-zero so this patch removes additional > memory allocation (page_ext) if debug_guardpage_minorder is zero. > > It saves memory if we just use debug_pagealloc and not guard page. We could also save cycles with a static key for _debug_guardpage_enabled :) But memory savings are likely more significant, so > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka