From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sunyeal Hong <sunyeal.hong@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] arm64: dts: exynos: add initial CMU clock nodes in ExynosAuto v920
Date: Wed, 24 Jul 2024 12:13:37 +0200 [thread overview]
Message-ID: <73922d54-2fb2-480b-a2af-1b1454429d52@kernel.org> (raw)
In-Reply-To: <20240722223333.1137947-3-sunyeal.hong@samsung.com>
On 23/07/2024 00:33, Sunyeal Hong wrote:
> Add cmu_top, cmu_peric0 clock nodes and
> switch USI clocks instead of dummy fixed-rate-clock.
>
> Signed-off-by: Sunyeal Hong <sunyeal.hong@samsung.com>
Thank you for your patch. There is something to discuss/improve.
> cpus: cpus {
> #address-cells = <2>;
> #size-cells = <0>;
> @@ -182,6 +172,28 @@ chipid@10000000 {
> reg = <0x10000000 0x24>;
> };
>
> + cmu_peric0: clock-controller@10800000 {
> + compatible = "samsung,exynosautov920-cmu-peric0";
> + reg = <0x10800000 0x8000>;
> + #clock-cells = <1>;
> +
> + clocks = <&xtcxo>,
> + <&cmu_top DOUT_CLKCMU_PERIC0_NOC>,
> + <&cmu_top DOUT_CLKCMU_PERIC0_IP>;
> + clock-names = "oscclk",
> + "noc",
> + "ip";
> + };
> +
> + cmu_top: clock-controller@11000000 {
This does not look ordered. Please read DTS coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-24 10:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240722223340epcas2p380657369f0b57c9e21f05f250066a711@epcas2p3.samsung.com>
2024-07-22 22:33 ` [PATCH v4 0/4] initial clock support for exynosauto v920 SoC Sunyeal Hong
[not found] ` <CGME20240722223340epcas2p4ab83b1e8dbc64eaaf32f4f8b7e3f015d@epcas2p4.samsung.com>
2024-07-22 22:33 ` [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings Sunyeal Hong
2024-07-23 20:57 ` Rob Herring
2024-07-25 1:24 ` sunyeal.hong
2024-07-25 3:03 ` sunyeal.hong
2024-07-25 6:21 ` Krzysztof Kozlowski
2024-07-25 6:35 ` sunyeal.hong
2024-07-25 6:37 ` Krzysztof Kozlowski
2024-07-25 6:40 ` Krzysztof Kozlowski
2024-07-25 7:14 ` sunyeal.hong
2024-07-25 7:31 ` Krzysztof Kozlowski
2024-07-25 7:50 ` sunyeal.hong
2024-07-25 7:56 ` Krzysztof Kozlowski
2024-07-29 2:48 ` sunyeal.hong
2024-07-24 10:12 ` Krzysztof Kozlowski
2024-07-25 1:25 ` sunyeal.hong
[not found] ` <CGME20240722223341epcas2p1b08b47cfefa981a2b31aad7878e3db64@epcas2p1.samsung.com>
2024-07-22 22:33 ` [PATCH v4 2/4] arm64: dts: exynos: add initial CMU clock nodes in ExynosAuto v920 Sunyeal Hong
2024-07-24 10:13 ` Krzysztof Kozlowski [this message]
2024-07-25 1:28 ` sunyeal.hong
2024-07-24 11:17 ` Tudor Ambarus
2024-07-25 3:09 ` sunyeal.hong
[not found] ` <CGME20240722223341epcas2p3937838f701942cc76b85858720e97a50@epcas2p3.samsung.com>
2024-07-22 22:33 ` [PATCH v4 3/4] clk: samsung: clk-pll: Add support for pll_531x Sunyeal Hong
[not found] ` <CGME20240722223341epcas2p499b4ab7179577972de0b0324be2005ba@epcas2p4.samsung.com>
2024-07-22 22:33 ` [PATCH v4 4/4] clk: samsung: add top clock support for ExynosAuto v920 SoC Sunyeal Hong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73922d54-2fb2-480b-a2af-1b1454429d52@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sunyeal.hong@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®