From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70DBC433EF for ; Thu, 24 Mar 2022 10:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349589AbiCXKrv (ORCPT ); Thu, 24 Mar 2022 06:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239291AbiCXKrt (ORCPT ); Thu, 24 Mar 2022 06:47:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 98FFA23BED for ; Thu, 24 Mar 2022 03:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648118777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SY8Zpg3HfKN7OLvRr+t2R2NBXsTqrDCHJm44fgalnyI=; b=H+0yYJohDgCfJzHIuhECwrzd2IoNwfRHJLnGknVRPE/PJlqjJBQiKjzhKgj2EWseTvCXdD gPbsufjNdnWqCpmARxMlLF3+JZZlWK+SXlljE2iKp2sPrUOps9Osl0VJtkVGwoTKRt+pVM zyXlIr2FjBeAU5tKMFoUxDt8NBET5UE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-BW_Gel20NwSvlDuFsDzpNg-1; Thu, 24 Mar 2022 06:46:16 -0400 X-MC-Unique: BW_Gel20NwSvlDuFsDzpNg-1 Received: by mail-wr1-f72.google.com with SMTP id e10-20020adf9bca000000b002059b6ffa18so200189wrc.14 for ; Thu, 24 Mar 2022 03:46:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=SY8Zpg3HfKN7OLvRr+t2R2NBXsTqrDCHJm44fgalnyI=; b=x2Vn501NvwOR0xkZpLRCQFHtJ8vWnJao4fU2y32SPQb3rLOp5MAE9Tjt4BN+QaszB1 89ggXN73aY69NJtMLfYTYdWlVxNgQbrm9KYZ3YAvAVZ3WIaS7EUh7dYbDYrOwQ1btVQj pjs8zfHofxBPs32MP9xu1DfQUfODW3iQeEGETaXCodu9q5sLlIydF+iJavWtGv1zIdnH 0k1uFksgJ4wh/f9rcy6fOqpXNCObwkF3RwH6rrX8Sm8UloBFy523AxarVQ2Bc+cZMrJx iwIJI2MJHGIQH9jVJcM5gegcUI8Fs9SnbDsL4bFdAXyNttSWgb6tI8Y1MJ4tq01XEgMZ +sGg== X-Gm-Message-State: AOAM5305V/ixdu2oj/w5LpscusB7bMNWy6S3KqR/KlWJNV9xTVUacdnw 7YhFGov/7ahKhCj/aFUVpp+gIkF3a+lZOLaKT6i0nr8UaJb3ALjJN4e8ytpBJhUA9Uv2jujiBDQ X0Ihijd8r7yZSikmptzCfu+D6 X-Received: by 2002:a05:6000:1083:b0:203:fbd3:937e with SMTP id y3-20020a056000108300b00203fbd3937emr3947179wrw.139.1648118775384; Thu, 24 Mar 2022 03:46:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqwK363x/lQQ7GkLV8cbmtKe+6jv7+DtEPxZLenuGRyjD62htTnjjltK8uF850hOZimwkWcw== X-Received: by 2002:a05:6000:1083:b0:203:fbd3:937e with SMTP id y3-20020a056000108300b00203fbd3937emr3947168wrw.139.1648118775167; Thu, 24 Mar 2022 03:46:15 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-232-135.dyn.eolo.it. [146.241.232.135]) by smtp.gmail.com with ESMTPSA id t4-20020a05600001c400b00203fb5dcf29sm2188758wrx.40.2022.03.24.03.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Mar 2022 03:46:14 -0700 (PDT) Message-ID: <7393b673c626fd75f2b4f8509faa5459254fb87c.camel@redhat.com> Subject: Re: [PATCH] bnx2x: replace usage of found with dedicated list iterator variable From: Paolo Abeni To: Jakob Koschel , Ariel Elior Cc: Sudarsana Kalluru , Manish Chopra , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Date: Thu, 24 Mar 2022 11:46:13 +0100 In-Reply-To: <20220324070816.58599-1-jakobkoschel@gmail.com> References: <20220324070816.58599-1-jakobkoschel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, 2022-03-24 at 08:08 +0100, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate iterator variable instead of a > found boolean [1]. > > This removes the need to use a found variable and simply checking if > the variable was set, can determine if the break/goto was hit. > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > Signed-off-by: Jakob Koschel This looks like a purely net-next change, and we are in the merge window: net-next is closed for the time being. Could you please re-post after net-next re-open? Additionally, I suggest you to bundle the net-next patches in a single series, namely: bnx2x: replace usage of found with dedicated list iterator variable octeontx2-pf: replace usage of found with dedicated list iterator variable sctp: replace usage of found with dedicated list iterator variable taprio: replace usage of found with dedicated list iterator variable that will simplify the processing, thanks! Paolo