From: Joe Perches <joe@perches.com>
To: Rajendra Nayak <rnayak@codeaurora.org>, srinivas.kandagatla@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, rbokka@codeaurora.org
Subject: Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change
Date: Fri, 23 Apr 2021 08:13:53 -0700 [thread overview]
Message-ID: <73945e7037ab61eb34a2a1af05aa3eef75c8f836.camel@perches.com> (raw)
In-Reply-To: <1619161503-8784-1-git-send-email-rnayak@codeaurora.org>
On Fri, 2021-04-23 at 12:35 +0530, Rajendra Nayak wrote:
> Fix a missed newline, and update a comment which is stale
> after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
> blowing on sc7280'
> No other functional change in this patch.
[]
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
[]
> @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
> }
>
> /*
> - * Hardware requires 1.8V min for fuse blowing; this may be
> + * Hardware requires a min voltage for fuse blowing; this may be
> * a rail shared do don't specify a max--regulator constraints
so don't?
> * will handle.
> */
but the comment doesn't make much overall sense to me.
next prev parent reply other threads:[~2021-04-23 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 7:05 Rajendra Nayak
2021-04-23 15:04 ` Doug Anderson
2021-04-26 4:18 ` Rajendra Nayak
2021-04-23 15:13 ` Joe Perches [this message]
2021-04-26 15:11 ` Doug Anderson
2021-04-27 2:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73945e7037ab61eb34a2a1af05aa3eef75c8f836.camel@perches.com \
--to=joe@perches.com \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbokka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®