mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alex Zhu (Kernel)" <alexlzhu@fb.com>
To: David Hildenbrand <david@redhat.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	Matthew Wilcox <willy@infradead.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"riel@surriel.com" <riel@surriel.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH 0/3] THP Shrinker
Date: Wed, 28 Sep 2022 16:22:34 +0000	[thread overview]
Message-ID: <73C02F96-49C7-4C1F-AF10-F6A61F1D68A4@fb.com> (raw)
In-Reply-To: <c4462af8-80a5-6cb6-8bfc-0e7ff1da6856@redhat.com>

Sorry about that. The diff to the RFC:

-Remove all THPs that are not in the top utilization bucket. This is what we have found to perform the best in production testing, we have found that there are an almost trivial number of THPs in the middle range of buckets that account for most of the memory waste. 

-Added check for THP utilization prior to split_huge_page for the THP Shrinker. This is to account for THPs that move to the top bucket, but were underutilized at the time they were added to the list_lru. 

-Refactored out the code to obtain the thp_utilization_bucket, as that now has to be used in multiple places.

-Multiply the shrink_count and scan_count by HPAGE_PMD_NR. This is because a THP is 512 pages, and should count as 512 objects in reclaim. This way reclaim is triggered at a more appropriate frequency than in the RFC. 

-Added support to map to the read only zero page when splitting a THP registered with userfaultfd. Also added a self test to verify that this is working. 

-Only trigger the unmap_clean/zap in split_huge_page on anonymous THPs. We cannot zap zero pages for file THPs.

Thanks,
Alex


  reply	other threads:[~2022-09-28 16:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  6:44 alexlzhu
2022-09-28  6:44 ` [PATCH 1/3] mm: add thp_utilization metrics to sysfs alexlzhu
2022-09-28  6:44 ` [PATCH 2/3] mm: changes to split_huge_page() to free zero filled tail pages alexlzhu
2022-09-28  8:48   ` Huang, Ying
2022-09-28 16:24     ` Alex Zhu (Kernel)
2022-10-01 20:39   ` kernel test robot
2022-09-28  6:44 ` [PATCH 3/3] mm: THP low utilization shrinker alexlzhu
2022-09-28 14:21 ` [PATCH 0/3] THP Shrinker David Hildenbrand
2022-09-28 16:22   ` Alex Zhu (Kernel) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-28  6:25 alexlzhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73C02F96-49C7-4C1F-AF10-F6A61F1D68A4@fb.com \
    --to=alexlzhu@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®