From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Mark Brown <broonie@kernel.org>, Dmitry Osipenko <digetx@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
drinkcat@chromium.org, dianders@chromium.org,
Liam Girdwood <lgirdwood@gmail.com>,
mka@chromium.org
Subject: Re: [PATCH] regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage
Date: Mon, 20 Jan 2020 13:10:18 +0100 [thread overview]
Message-ID: <73a24487-d9ff-88c3-2516-69ae89915c88@collabora.com> (raw)
In-Reply-To: <20200120120830.GA6852@sirena.org.uk>
On 20/1/20 13:08, Mark Brown wrote:
> On Fri, Jan 17, 2020 at 07:28:04PM +0300, Dmitry Osipenko wrote:
>> 16.01.2020 12:45, Enric Balletbo i Serra пишет:
>
>>> +EXPORT_SYMBOL(regulator_set_voltage_rdev);
>>>
>>> static int regulator_limit_voltage_step(struct regulator_dev *rdev,
>>> int *current_uV, int *min_uV)
>>> @@ -4034,6 +4035,7 @@ int regulator_get_voltage_rdev(struct regulator_dev *rdev)
>>> return ret;
>>> return ret - rdev->constraints->uV_offset;
>>> }
>>> +EXPORT_SYMBOL(regulator_get_voltage_rdev);
>
>> I think it should be EXPORT_SYMBOL_GPL().
>
> Yes, you're right.
>
Oops, right, Mark do you want me to send a follow-up patch, a second version or
you can just apply a fix?
Thanks,
Enric
next prev parent reply other threads:[~2020-01-20 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 9:45 Enric Balletbo i Serra
2020-01-17 15:44 ` Applied "regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage" to the regulator tree Mark Brown
2020-01-17 16:28 ` [PATCH] regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage Dmitry Osipenko
2020-01-20 12:08 ` Mark Brown
2020-01-20 12:10 ` Enric Balletbo i Serra [this message]
2020-01-20 12:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a24487-d9ff-88c3-2516-69ae89915c88@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=drinkcat@chromium.org \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®