From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADADD2749FC for ; Tue, 20 May 2025 10:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747738708; cv=none; b=SgFhSiD4J5nRtGzU22arXojbJmanBWLef5tHyjNtxvfK9W/g9Q6feWkhfCSrv0mIR/cqAws2tNtA/5CswgoQTjqMSxMjX7njRZtJb8oIVBErkoI3dO85SPdRrcAowOtH2FqZI1XSUvzyGBPOBZ9ACvrYhv2UfH84HuRtdVfudik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747738708; c=relaxed/simple; bh=XCjhuqMISSLiz8GE+zUfY3bVdPUVO6omDyP1PQiJ4QE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sKkdis0hyHBxzc4lmbDICPC/cRr9krUtktk2cIMhFo1nPcBAg34iBYxOoy14wXUVPQkV8924YVsn3tAalKEDQ83lZvPGyFuTzw1qn0/ks7X+niheQS3APRGmKur5nos1UjJU/HwHNInxiJNwQQOkAmiaLNthU03XvjTnn0FcAUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UZCxduii; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UZCxduii" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747738705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D274b/Kowlx4frHiCJWZP9nEutUPctu6wUBTBcBAl+Q=; b=UZCxduiiwG1i3l5yH8810Rrkg3u55lHPVTYquZqV7p81FwpEt3eH+8DYwVEiJTLuDX6PeY vG+MC/EG/ZoBAtchDhKj/+1RYLAzYikOkA+TE54MK4jj3Zb/8Y7UtaTGZ3x2w4OmeJAp1s bYtz5uLyHfPxU7pxh2IZ/k701NFAqyI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-VMbI29GNPuyxvJaRRqNgOQ-1; Tue, 20 May 2025 06:58:22 -0400 X-MC-Unique: VMbI29GNPuyxvJaRRqNgOQ-1 X-Mimecast-MFC-AGG-ID: VMbI29GNPuyxvJaRRqNgOQ_1747738701 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d007b2c79so42950775e9.2 for ; Tue, 20 May 2025 03:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747738701; x=1748343501; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D274b/Kowlx4frHiCJWZP9nEutUPctu6wUBTBcBAl+Q=; b=TKMKjN7JdwVSm86bqGFca7PBT7dXAKp0xmEc2odacxQGuu31ziFfKGVZjXL9N/V+YY Cd6iOgI81VfNOd+9qD+J4c2Zk9dDU4J2RJ2odHgau9FpLJ9X/tKa3EMZbEKU1yPq8L0C HS0CFy3JoVUFm3FXRZsWliLaIfIXHCMduHM237WEhvNBOXejPv9E0itqy1w4LxRviPxj 51N4OWi4QOI0snzd4E7TPd6R1wYcjmCqc29WdBk+yEZOjdQJ/sor/I4GwGQAC4HQ0brp wtHW8SPMfSm4/BbvXFQr9CSH7w9ar0i+b74uqU0j3sH+TBEKRcDKjMRU6i2Unc1e5Q0g Ucrw== X-Forwarded-Encrypted: i=1; AJvYcCX7AkOdWJb2NEulOs1E6YCcFkFWajs+xjUETruDNsnkJ4KxSAULPFCqsiVF/sfL2lFg3UEyxt7dELvxP2c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5lzr/hurP5YTAXLLso9Kqr5eoX7r2PDbJAf/Rlo+Eu8IWP0Uq 1kChhM8ceERXLmtJktITAnLoVhZ6Z6LeacF+nEmq+8VKvuLx3QSAwLw7s9yTsEORsNZo8lhB0iy S7lGaJqBWZNL6cgsD3/t+45VHjNIOJFyjYi3L2tAqafEWhSrcmXN5IZcqXtBh3jc6dA== X-Gm-Gg: ASbGncvMDRJ979hIWIrE/6DjTydxzVTjLGeRj6iaiND89z8ggcVZWHdw3qMo16yxUNo fW0u/xP4tzZnnMjVi+lgFc3AsINCu6Kn6o/tF8zRTxjlnjMtNzm8Z83p0EZGnLBaFL+AVbdxfK3 5zdsQFWR/brlvT5vPYHcpf6Eo0koRPuWB9EuW+mFiKWjjnQbstCX9c95ocWAFhMZYRdlDnlId/+ cowbLSEEJiqNBzeCTm4aFRDhRfzrfAOawSlctqEOB6t+jai5Vf5zFIt4tpMd+Eh9d0m+8URL5jG uUEfWuKFlRQuN+sQBMk/LPjcBHCREvfHR3f83WNe0CFPY4jc9/DBqOsekek= X-Received: by 2002:a05:600c:34c9:b0:43d:fa59:af97 with SMTP id 5b1f17b1804b1-442fd671d12mr138378645e9.32.1747738701186; Tue, 20 May 2025 03:58:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvQyiml0UoaDF/88g9sn8ucNfch1PfIPLwL2A/DSRiTilof5rRlAsf3z16t0LsF6Ckj58VyA== X-Received: by 2002:a05:600c:34c9:b0:43d:fa59:af97 with SMTP id 5b1f17b1804b1-442fd671d12mr138378435e9.32.1747738700827; Tue, 20 May 2025 03:58:20 -0700 (PDT) Received: from ?IPV6:2a0d:3344:244f:5710:ef42:9a8d:40c2:f2db? ([2a0d:3344:244f:5710:ef42:9a8d:40c2:f2db]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca9417dsm15708833f8f.101.2025.05.20.03.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 03:58:20 -0700 (PDT) Message-ID: <73a4740e-755e-4ba8-8130-df09bd25197a@redhat.com> Date: Tue, 20 May 2025 12:58:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7] selftests/vsock: add initial vmtest.sh for vsock To: Stefano Garzarella , Bobby Eshleman Cc: Stefan Hajnoczi , Shuah Khan , kvm@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20250515-vsock-vmtest-v7-1-ba6fa86d6c2c@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/20/25 10:24 AM, Stefano Garzarella wrote: > On Thu, May 15, 2025 at 03:00:48PM -0700, Bobby Eshleman wrote: >> This commit introduces a new vmtest.sh runner for vsock. >> >> It uses virtme-ng/qemu to run tests in a VM. The tests validate G2H, >> H2G, and loopback. The testing tools from tools/testing/vsock/ are >> reused. Currently, only vsock_test is used. >> >> VMCI and hyperv support is automatically built, though not used. >> >> Only tested on x86. >> >> To run: >> >> $ make -C tools/testing/selftests TARGETS=vsock >> $ tools/testing/selftests/vsock/vmtest.sh > > I am a little confused, now we have removed the kernel build step, so > how should I test this? (It's running my fedora kernel, but then ssh > fails to connect) > > Would it be better to re-introduce the build phase at least in the > script as optional (not used by selftest, but usable if you want to use > the script directly)? > > Or at least I think we should explain that the script launches the > running kernel, because the config file introduced by this patch > confused me. How it's supposed to be used? This is the usual selftests schema. The user has to build and install the kernel including the specified config before running the tests, see make help |grep kselftest Also this is what we do for our CI: https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style @Bobby: AFAICS this now has all the ingredients to fit NIPA integration am I correct? the last commit message sentence could possibly be dropped. Still it could be worthy to re-introduce (behind a command line option) the ability to build the kernel as per Stefano request, to fit his existing workflow (sorry for the partial back and forth). Thanks, Paolo