From: Dave Hansen <dave.hansen@intel.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
Alex Shi <alex.shi@linux.alibaba.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Aubrey Li <aubrey.li@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/fpu: remove unused macros
Date: Tue, 21 Jan 2020 15:07:23 -0800 [thread overview]
Message-ID: <73a88e85-6995-6e3e-5eb8-a8c2b233364d@intel.com> (raw)
In-Reply-To: <20200121114326.GF2437@uranus>
On 1/21/20 3:43 AM, Cyrill Gorcunov wrote:
> On Tue, Jan 21, 2020 at 04:50:11PM +0800, Alex Shi wrote:
>> NR_VALID_PKRU_BITS/PKRU_VALID_MASK are never used after it was
>> introduced. So better to remove them.
> Dave moved them in so while they are not used indeed better to
> get approve from him (to be sure they were not reserved for
> future development).
>
> Initial commit 8459429693395ca9e8d18101300b120ad9171795
FWIW, I'm not a massive fan of blindly removing stuff like this. Maybe
it's better to remove the cruft, but it's even better to try to figure
out why I might have added them in the first place. :)
I *think* it was an attempt to ensure that a resulting PKRU value can be
written to PKRU, independent of the type it was stored as.
Let me see if I can come up with something nicer than ripping these out.
next prev parent reply other threads:[~2020-01-21 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:50 Alex Shi
2020-01-21 11:43 ` Cyrill Gorcunov
2020-01-21 23:07 ` Dave Hansen [this message]
2020-01-22 6:51 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a88e85-6995-6e3e-5eb8-a8c2b233364d@intel.com \
--to=dave.hansen@intel.com \
--cc=alex.shi@linux.alibaba.com \
--cc=aubrey.li@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®