From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbdBITGC (ORCPT ); Thu, 9 Feb 2017 14:06:02 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:19139 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752301AbdBITGA (ORCPT ); Thu, 9 Feb 2017 14:06:00 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Wed, 08 Feb 2017 23:00:19 -0800 Subject: Re: [PATCH v2] vfio/mdev: Use a module softdep for vfio_mdev To: Alex Williamson References: <20170208221526.19509.30858.stgit@gimli.home> CC: , X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <73aaa70c-e56a-2713-410b-9a492571fa76@nvidia.com> Date: Fri, 10 Feb 2017 00:35:46 +0530 MIME-Version: 1.0 In-Reply-To: <20170208221526.19509.30858.stgit@gimli.home> X-Originating-IP: [10.24.71.105] X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/2017 3:46 AM, Alex Williamson wrote: > Use an explicit module softdep rather than a request module call such > that the dependency is exposed to userspace. This allows us to more > easily support modules loaded at initrd time. > > Signed-off-by: Alex Williamson > --- > Looks good to me. Reviewed by: Kirti Wankhede Thanks, Kirti > v2: Remove request_module call as well, update description. > > drivers/vfio/mdev/mdev_core.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 36d75c367d22..126991046eb7 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -422,18 +422,7 @@ int mdev_device_remove(struct device *dev, bool force_remove) > > static int __init mdev_init(void) > { > - int ret; > - > - ret = mdev_bus_register(); > - > - /* > - * Attempt to load known vfio_mdev. This gives us a working environment > - * without the user needing to explicitly load vfio_mdev driver. > - */ > - if (!ret) > - request_module_nowait("vfio_mdev"); > - > - return ret; > + return mdev_bus_register(); > } > > static void __exit mdev_exit(void) > @@ -451,3 +440,4 @@ static void __exit mdev_exit(void) > MODULE_LICENSE("GPL v2"); > MODULE_AUTHOR(DRIVER_AUTHOR); > MODULE_DESCRIPTION(DRIVER_DESC); > +MODULE_SOFTDEP("post: vfio_mdev"); >