From: Leonard Crestez <leonard.crestez@nxp.com>
To: "Sven.Schmitt@mixed-mode.de" <Sven.Schmitt@mixed-mode.de>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"etnaviv@lists.freedesktop.org" <etnaviv@lists.freedesktop.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [PATCH v3 2/3] soc: imx: gpc: clean up
Date: Tue, 24 Jul 2018 11:45:23 +0000 [thread overview]
Message-ID: <73b2d272a68ba6a21c62857733f5333a30323fcc.camel@nxp.com> (raw)
In-Reply-To: <1532425561377.1081@mixed-mode.de>
On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> Remove unused #defines.
This should be the title of the patch, "clean up" is too vague.
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -24,15 +24,11 @@
> #define GPC_PGC_CTRL_OFFS 0x0
> #define GPC_PGC_PUPSCR_OFFS 0x4
> #define GPC_PGC_PDNSCR_OFFS 0x8
> -#define GPC_PGC_SW2ISO_SHIFT 0x8
> -#define GPC_PGC_SW_SHIFT 0x0
It would be cleaner if you used these defines when reading the sw/iso
values.
>
> #define GPC_PGC_PCI_PDN 0x200
> #define GPC_PGC_PCI_SR 0x20c
>
> #define GPC_PGC_GPU_PDN 0x260
> -#define GPC_PGC_GPU_PUPSCR 0x264
> -#define GPC_PGC_GPU_PDNSCR 0x268
> #define GPC_PGC_GPU_SR 0x26c
Each PGC has a fixed size and layout, maybe we could just have defines
for the offset of the PGC? It would be somewhat similar to gpcv2
prev parent reply other threads:[~2018-07-24 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 9:46 Sven Schmitt
2018-07-24 11:45 ` Leonard Crestez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73b2d272a68ba6a21c62857733f5333a30323fcc.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=Sven.Schmitt@mixed-mode.de \
--cc=etnaviv@lists.freedesktop.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®