From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E3DC433E2 for ; Mon, 14 Sep 2020 00:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18B9521D1A for ; Mon, 14 Sep 2020 00:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HFkRkDPO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbgINAtQ (ORCPT ); Sun, 13 Sep 2020 20:49:16 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26210 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725978AbgINAtL (ORCPT ); Sun, 13 Sep 2020 20:49:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600044550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ghr5orKu6aikpqEdskdLQXzPfKKUxCEDmVqKYdI6iBc=; b=HFkRkDPOJuQrm495jcsfjUCmrPKddHy15H44p0l10DJV29aSp3YowDQO5sl5kyW1tfnGBE dAEQ5gckhkrKfbZc9vVxlVu6j8KND15yMSNTh9klcuJa1cV82EkNkJwgo+/fQbfEyhc219 Q8AWPjs1FeIMHST12cuVMq8U0pVmpAI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-gFHhDZXQMyGmwnYw-_oZFw-1; Sun, 13 Sep 2020 20:49:05 -0400 X-MC-Unique: gFHhDZXQMyGmwnYw-_oZFw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7DB18425CB; Mon, 14 Sep 2020 00:49:03 +0000 (UTC) Received: from llong.remote.csb (ovpn-113-90.rdu2.redhat.com [10.10.113.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id D919F60BF3; Mon, 14 Sep 2020 00:49:01 +0000 (UTC) Subject: Re: [PATCH 2/3] mm/memcg: Simplify mem_cgroup_get_max() To: Shakeel Butt Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , LKML , Cgroups , Linux MM , Chris Down , Roman Gushchin , Yafang Shao References: <20200820130350.3211-1-longman@redhat.com> <20200820130350.3211-3-longman@redhat.com> <20200820173546.GB912520@cmpxchg.org> From: Waiman Long Organization: Red Hat Message-ID: <73bab001-b819-1e6d-e130-c52ae2206f19@redhat.com> Date: Sun, 13 Sep 2020 20:49:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/20/20 5:25 PM, Shakeel Butt wrote: > On Thu, Aug 20, 2020 at 1:29 PM Waiman Long wrote: >> On 8/20/20 1:35 PM, Johannes Weiner wrote: >>> On Thu, Aug 20, 2020 at 09:03:49AM -0400, Waiman Long wrote: >>>> The mem_cgroup_get_max() function used to get memory+swap max from >>>> both the v1 memsw and v2 memory+swap page counters & return the maximum >>>> of these 2 values. This is redundant and it is more efficient to just >>>> get either the v1 or the v2 values depending on which one is currently >>>> in use. >>>> >>>> Signed-off-by: Waiman Long >>>> --- >>>> mm/memcontrol.c | 14 +++++--------- >>>> 1 file changed, 5 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >>>> index 26b7a48d3afb..d219dca5239f 100644 >>>> --- a/mm/memcontrol.c >>>> +++ b/mm/memcontrol.c >>>> @@ -1633,17 +1633,13 @@ void mem_cgroup_print_oom_meminfo(struct mem_cgroup *memcg) >>>> */ >>>> unsigned long mem_cgroup_get_max(struct mem_cgroup *memcg) >>>> { >>>> - unsigned long max; >>>> + unsigned long max = READ_ONCE(memcg->memory.max); >>>> >>>> - max = READ_ONCE(memcg->memory.max); >>>> if (mem_cgroup_swappiness(memcg)) { >>>> - unsigned long memsw_max; >>>> - unsigned long swap_max; >>>> - >>>> - memsw_max = memcg->memsw.max; >>>> - swap_max = READ_ONCE(memcg->swap.max); >>>> - swap_max = min(swap_max, (unsigned long)total_swap_pages); >>>> - max = min(max + swap_max, memsw_max); >>>> + if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) >>>> + max += READ_ONCE(memcg->swap.max); >>>> + else >>>> + max = memcg->memsw.max; >>> I agree with the premise of the patch, but v1 and v2 have sufficiently >>> different logic, and the way v1 overrides max from the innermost >>> branch again also doesn't help in understanding what's going on. >>> >>> Can you please split out the v1 and v2 code? >>> >>> if (cgroup_subsys_on_dfl(memory_cgrp_subsys)) { >>> max = READ_ONCE(memcg->memory.max); >>> if (mem_cgroup_swappiness(memcg)) >>> max += READ_ONCE(memcg->swap.max); >>> } else { >>> if (mem_cgroup_swappiness(memcg)) >>> max = memcg->memsw.max; >>> else >>> max = READ_ONCE(memcg->memory.max); >>> } >>> >>> It's slightly repetitive, but IMO much more readable. >>> >> Sure. That makes it even better. >> > Can you please also add in the commit message why it is ok to drop > total_swap_pages comparison from mem_cgroup_get_max()? > My bad. I accidentally skipped the total_swap_pages check. Will add it back in v2. Cheers, Longman