From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jerome Brunet" <jbrunet@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dave Ertman" <david.m.ertman@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Conor.Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Doug Anderson" <dianders@chromium.org>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"laurent.pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Abel Vesa" <abelvesa@kernel.org>, "Peng Fan" <peng.fan@nxp.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
dri-devel@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org, linux-mips@vger.kernel.org,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2
Date: Thu, 13 Feb 2025 13:26:12 +0100 [thread overview]
Message-ID: <73c1ab6b-fd5e-47e3-8815-8f74758535f1@app.fastmail.com> (raw)
In-Reply-To: <20250211-aux-device-create-helper-v3-7-7edb50524909@baylibre.com>
On Tue, Feb 11, 2025, at 18:28, Jerome Brunet wrote:
>
> I also think this is more readeable and maintainable than a bunch of
> 'default CONFIG_FOO if CONFIG_FOO' for CONFIG_RESET_MESON_AUX. This approach
> also would have several pitfall, such as picking the value of the first config
> set or the config of RESET_MESON_AUX staying to 'n' if CONFIG_FOO is turned on
> with menuconfig.
I still think you should just drop the 'imply' line, all it does it
force reviewers to double-check that you didn't make a mistake
here, so it's a waste of time.
Arnd
next prev parent reply other threads:[~2025-02-13 12:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 17:27 [PATCH v3 0/7] driver core: auxiliary bus: add device creation helper Jerome Brunet
2025-02-11 17:27 ` [PATCH v3 1/7] driver core: auxiliary bus: add device creation helpers Jerome Brunet
2025-02-14 16:33 ` Greg Kroah-Hartman
2025-02-14 18:16 ` Jerome Brunet
2025-02-15 6:53 ` Greg Kroah-Hartman
2025-02-17 18:10 ` Jerome Brunet
2025-02-18 8:14 ` Greg Kroah-Hartman
2025-02-11 17:27 ` [PATCH v3 2/7] reset: mpfs: use the auxiliary device creation helper Jerome Brunet
2025-02-13 17:59 ` Conor Dooley
2025-02-14 8:59 ` Jerome Brunet
2025-02-14 15:25 ` Doug Anderson
2025-02-15 12:50 ` Conor Dooley
2025-02-11 17:28 ` [PATCH v3 3/7] drm/bridge: ti-sn65dsi86: " Jerome Brunet
2025-02-12 16:38 ` Doug Anderson
2025-02-13 10:10 ` Jerome Brunet
2025-02-11 17:28 ` [PATCH v3 4/7] platform: arm64: lenovo-yoga-c630: " Jerome Brunet
2025-02-13 12:56 ` Ilpo Järvinen
2025-02-11 17:28 ` [PATCH v3 5/7] clk: eyeq: " Jerome Brunet
2025-02-12 14:41 ` [PATCH] reset: eyeq: drop device_set_of_node_from_dev() done by parent Théo Lebrun
2025-02-12 14:51 ` [PATCH v3 5/7] clk: eyeq: use the auxiliary device creation helper Théo Lebrun
2025-02-11 17:28 ` [PATCH v3 6/7] clk: clk-imx8mp-audiomix: " Jerome Brunet
2025-02-14 16:15 ` Ira Weiny
2025-02-14 18:20 ` Jerome Brunet
2025-02-14 22:03 ` Ira Weiny
2025-02-11 17:28 ` [PATCH v3 7/7] clk: amlogic: axg-audio: use the auxiliary reset driver - take 2 Jerome Brunet
2025-02-12 14:53 ` Théo Lebrun
2025-02-13 10:16 ` Jerome Brunet
2025-02-13 12:26 ` Arnd Bergmann [this message]
2025-02-13 13:35 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c1ab6b-fd5e-47e3-8815-8f74758535f1@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=abelvesa@kernel.org \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=ira.weiny@intel.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=theo.lebrun@bootlin.com \
--cc=tzimmermann@suse.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®