From: Brian Gerst <brgerst@gmail.com>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Ingo Molnar <mingo@elte.hu>, Tejun Heo <htejun@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 #tj-percpu] x86: fix build breakage on voyage
Date: Tue, 27 Jan 2009 11:25:56 -0500 [thread overview]
Message-ID: <73c1f2160901270825y5e7f3974m830c399074c2e8f1@mail.gmail.com> (raw)
In-Reply-To: <1233072253.3231.47.camel@localhost.localdomain>
On Tue, Jan 27, 2009 at 11:04 AM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Tue, 2009-01-27 at 16:50 +0100, Ingo Molnar wrote:
>> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>>
>> > On Tue, 2009-01-27 at 12:37 +0100, Ingo Molnar wrote:
>> > > * Tejun Heo <htejun@gmail.com> wrote:
>> > >
>> > > > From: James Bottomley <James.Bottomley@HansenPartnership.com>
>> > > >
>> > > > Impact: build fix
>> > > >
>> > > > x86_cpu_to_apicid and x86_bios_cpu_apicid aren't defined for voyage.
>> > > > Earlier patch forgot to conditionalize early percpu clearing. Fix it.
>> > >
>> > > > +#ifdef CONFIG_X86_LOCAL_APIC
>> > > > early_per_cpu_ptr(x86_cpu_to_apicid) = NULL;
>> > > > early_per_cpu_ptr(x86_bios_cpu_apicid) = NULL;
>> > > > +#endif
>> > >
>> > > That patch is not acceptable - it is ugly and it adds another set of
>> > > #ifdefs to an already complex piece of code.
>> > >
>> > > As i explained it to James in recent threads, the clean and acceptable
>> > > solution to this class of problems is to switch Voyager away from that
>> > > fragile subarch code to proper generic x86 code. (just like we did it for
>> > > other subarchitectures)
>> > >
>> > > There is nothing in Voyager that justifies special treatment in the area
>> > > of x86 percpu code.
>> > >
>> > > This is one of the mails that explains the principles:
>> > >
>> > > http://lkml.indiana.edu/hypermail/linux/kernel/0901.2/00954.html
>> > >
>> > > Or - if there's no time/interest in doing that, we can mark Voyager as
>> > > CONFIG_BROKEN.
>> >
>> > Have you quite finished?
>>
>> What is that supposed to mean?
>
> It's a conventional response implying your rant wasn't factually
> connected to the actual problem at hand. The justification was actually
> in the text you cut ... but boils down to you can reproduce it in a non
> voyager configuration, so it's not a voyager specific problem.
>
> The actual problem, as I see it, is how (or whether) to get rid of the
> nine #if/#ifdefs that clutter setup_percpu.c ... none of which is
> voyager specific.
To be fair, setup_percpu.c isn't built on UP. But we're splitting
hairs over just 3 conditional variables. I'm open to ideas, but I'm
quite certain that any general solution will have more overhead than
the current code. I am looking at a patch to remove the early percpu
pointers, so the second set of ifdefs would go away.
--
Brian Gerst
next prev parent reply other threads:[~2009-01-27 16:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090126103243.GA31307@elte.hu>
2009-01-26 13:44 ` [PATCH] x86-32: Fix __per_cpu_load relocation Brian Gerst
2009-01-26 14:18 ` Ingo Molnar
2009-01-27 2:02 ` Tejun Heo
2009-01-27 4:03 ` Tejun Heo
2009-01-27 5:03 ` James Bottomley
2009-01-27 5:29 ` [PATCH 1/2 #tj-percpu] x86: fix build breakage on voyage Tejun Heo
2009-01-27 5:29 ` [PATCH 2/2 #tj-percpu] x86: clean up indentation in setup_per_cpu_areas() Tejun Heo
2009-01-27 11:37 ` [PATCH 1/2 #tj-percpu] x86: fix build breakage on voyage Ingo Molnar
2009-01-27 11:47 ` Tejun Heo
2009-01-27 12:50 ` Brian Gerst
2009-01-27 13:11 ` Ingo Molnar
2009-01-27 13:21 ` Ingo Molnar
2009-01-27 15:33 ` James Bottomley
2009-01-27 15:31 ` James Bottomley
2009-01-27 15:50 ` Ingo Molnar
2009-01-27 16:04 ` James Bottomley
2009-01-27 16:25 ` Brian Gerst [this message]
2009-01-27 16:53 ` James Bottomley
2009-01-27 10:52 ` [PATCH] x86-32: Fix __per_cpu_load relocation Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c1f2160901270825y5e7f3974m830c399074c2e8f1@mail.gmail.com \
--to=brgerst@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®