From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45ECB3E5570 for ; Mon, 8 Jun 2026 19:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780946603; cv=none; b=K+2TzETTWEK7nCrsqDAm0jrNUt8pOyyRH/Jku77eSGYZIzIVnnyhVT3ijGuhUEAanylbu9VUVc0ttBulWKXYXOExbFR/eLtlXHXEnQROibJ4P231vv6Q5BYpZMwKAblJubFI+oZaW6zkgagBRb6g25iKTchHTCj5Tnz6UIrieoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780946603; c=relaxed/simple; bh=nuRsw70T5Asbww0avPVZfHHVwOjUESUE6/ISQDRJ31o=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=gAnkil6DBEDI0ot9hlsWZm1nJppz5xljVjwzPXQCtri7EyKzTtJzvLFiGU4RAir+yRIFYRxjSRnE4JiRhPM3ciV3QgMmjNMKF48Z7xFICrXNi5qk5dUojVvu5UrPBegxpqkp/NUuoNNisKBhxXJsagC5xPL1TBRPK7lbqSfE4s4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mfY2HWmM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jHc7QI22; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mfY2HWmM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jHc7QI22" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 658IxARn346367 for ; Mon, 8 Jun 2026 19:23:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6dxPPr7ceOWyQ4IQHmVd8HESJuuEGxHUdgZy+22Akyw=; b=mfY2HWmMJ7pVn9YH bwCiPVSVo9oVWpNOuXxc9sELa0/mYI8k5qb41uu+pAIIhfTKq31fHKQAsO1aufg7 0FQv5MXW4Y2iM9bQdRP3N5dbwG7hDUbZorO/Ag0moZDViKnznVKb+dPLlu53LruN +YzA0qXP9QFVxr7GpJjLxXQpieDS5K4/sC0JAlBS54qsl9ETWTqqacQ6tbZ89ZpE ncfE4XEsiWZXIFlZdR+G4+Ky4F+Y/wozj0TlZBUt+rZ92agzAnXs65C/eX94DQlX kWmta1J3SCw9XPsj8w72Qs4/1TeIWpqepX21SkoPvorUB3A1xlBf2o5cs/1Y7glq g5eNTA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4enxee1tam-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 19:23:21 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51760f997fdso145523781cf.2 for ; Mon, 08 Jun 2026 12:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780946600; x=1781551400; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=6dxPPr7ceOWyQ4IQHmVd8HESJuuEGxHUdgZy+22Akyw=; b=jHc7QI225NMGPnPhtJcOQKv4d+CgvCdnh48+ApfwQfKhegKcR4nlWJZqvF+xOSCfHv Uyknl57bGb6cfqX+HRFIYjVgRZ2cIYBp8lc5Pph8d7TxQtMWDs5Hko+4mxTMT/mO1PF2 YG7cd0pWnORl1NzpJ9aL7Syp1LN+Q3hqA1GsJOi0OCxbv+8/graF9JPYq2T9RiZLfq8s 6scW0d+B4+gbexMQQRAFCgm3lbHkW0wZC94wr2M0TL4Xh0cm5Z4UhtTipscEzYXxRmEi Ckuaj0YvoyeGNiOHuPVKA0v9RaV40gXOCtvgNyEeTnyYFh0VOQnQA8R4vj0HOU5EG5z5 hRag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780946600; x=1781551400; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6dxPPr7ceOWyQ4IQHmVd8HESJuuEGxHUdgZy+22Akyw=; b=DH2ykJkYDfwknjcK/nEPSs0Cy/wFAZ8fhmDcup+mIaDuS3y+VW8wwzCDgIQil+WUCK DoGuWS5lgrIdZl5nxFGblpGLRaEN36w/hRF7JABcCcH3deaPCcjchjeDIvHHFFhVNoD3 3+9GFNSC1ufnPlY7dRwW9wnIKSPFXJWNvpghcwyYY2wSHniI+u7tPDE+ANkgJbHZNsnn qj4wgiu4SemCETgKO4QC+5HsKjSPbFIMJ6v8p7go756WREk1JA/e8GQf0Iam/DxE3ntO 0tyUSq2Q+sPAnD9+F3UdJjFYUHGTVO08I8wnRMqprLhdwYSolBalHEZUqY/7eCnikgVB dtQg== X-Forwarded-Encrypted: i=1; AFNElJ/6/t/WLN5+XavE+bx1k1NiPvk/rX5htoWsjmiegqe0QkN15OKOESZ0E/+3SUJQZV8JiA5eDLNmJVHrSZE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx82B5PoZYaRCVIQa0Cyv0K3uWn/URBFj9vk1BDWo7xoQENtVet okSEWyKDYXF9wJbIeG9Y7kifQHrOxti9NCMVi6WuBCT67o+Wu5liWkpXgSv3tRDcbflYZOJncTn eM5PSthK85inwJOZ1VWisuwfTVtrs9Yn8iCYYdRX4wQiQx2Yd2HTvLqOUKmb56noyVsPAcqaxxw w= X-Gm-Gg: Acq92OEHydTA7R08m+7GLjjS6iV7wDVzRScQ2op7hCkykscjRSwJ/FbuCF3dVlJc8j+ rMgY45N/RX+Bu3GmxFeeUwXrBxsbZdDfC3ivtyYkKz+l9rf0aVGC3slYHWb8P/lsE9taLbQjrmk abx1RIaV7gweNZ+b393dlm2V6vNHlhYsuS8SITAj7UFQGHcPFYtYyaorlnsl+asq4y6PCibsf1H fJ1zdaehTjjc8BYjCP1Nt7/ilIsBYzZMsfYmakSuowbqsVkkqInoUFahJ/Xc75+lc9D5YBiEEh4 UeKgB9dM5ZYiSuXTOPmNx2/yqeeok3o7Qzbfnws23g2p8AkwsYsJyL5cltzcwH9ps+QatTKKVDU 1q0UUBVuMnaQxIcFAW+hYqwP8Yi21KIIL37L3tXhK5Nw+q2lA0qW5qwRobPwx4+6cf1r2M05I3S sYOzXqeXyFDvwJV5oh/6nN9c6O3w6SYIm1pEvGCegGn3gEZ4mYeU/vel87AwuXqXF4b0CQ1qXUL 1OPelbFQRP+fNmTuiJKfU4kV+4= X-Received: by 2002:a05:622a:2613:b0:517:79f0:ae4d with SMTP id d75a77b69052e-517a12d2d6amr217602951cf.19.1780946600386; Mon, 08 Jun 2026 12:23:20 -0700 (PDT) X-Received: by 2002:a05:622a:2613:b0:517:79f0:ae4d with SMTP id d75a77b69052e-517a12d2d6amr217602431cf.19.1780946599886; Mon, 08 Jun 2026 12:23:19 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf055500875sm906309466b.53.2026.06.08.12.23.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 12:23:19 -0700 (PDT) Message-ID: <73c27728-2f07-41c1-82c7-fd6f46c89f3c@oss.qualcomm.com> Date: Mon, 8 Jun 2026 21:23:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v5] platform/x86/lenovo: Add Yoga Book 9 keyboard dock detection driver To: Dave Carey Cc: platform-driver-x86@vger.kernel.org, pithenrich2d@googlemail.com, mpearson-lenovo@squebb.ca, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, armin.wolf@outlook.de, linux-kernel@vger.kernel.org References: <20260521144034.282419-1-carvsdriver@gmail.com> <20260527122701.242907-1-carvsdriver@gmail.com> <78833ba9-7ea0-4c7f-8d41-ac0fd64ba15c@oss.qualcomm.com> <20260608125211.11957-1-carvsdriver@gmail.com> <20260608190507.77836-1-carvsdriver@gmail.com> Content-Language: en-US, nl In-Reply-To: <20260608190507.77836-1-carvsdriver@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDE3OCBTYWx0ZWRfX+EM036mT+UJ2 VOegDNjxubwSAcj1WFcRNxywB9Ci1Ojip+1Q/JphYDM2RvPh/wwJNOI6lYMmVEopt5xd6TQyr9j w4tiCnNRmTL38jR+Bw+UuMMzP1hPNStr7ZmW9pKoxYvTME9H8NpJQpLlqdnM3BfI1NtKscWWMC4 TkK8nsLq6Ps49RBjbZQdvvAhvsUoCtqhc38qnqUYIdVIZ2uioS044dV5lUAPfYHx1qp95szg92K jpf1LIhcHyV3mCsviGgMoMfhvhfF1O3hnb7fP0F4Uk/wrKvZFdvzeZ4uNG9Q5huJX6ucFxbfat3 VT6RoSJ3kEHU/+8Xoy2kxtzRw8r34YNFg+inOL+ScF5s3pRvYRMqoWHTEQRVK89lgimcIRKL9fY O8wFQqBZtxlDJbzdpK2jTqCAPkOHkhljK69D1hw74DZ1yEVMBIG3IUCLyuBOch2VvosehdydvDu 0TDw8ohtCG2oP/gKq8w== X-Authority-Analysis: v=2.4 cv=V6BNF+ni c=1 sm=1 tr=0 ts=6a2716a9 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=iw09b_tlpInP9k3BYecA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: 15hDsrlS01FIsmuELUphaLjfcZ4zXbqy X-Proofpoint-ORIG-GUID: 15hDsrlS01FIsmuELUphaLjfcZ4zXbqy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_05,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080178 Hi, On 8-Jun-26 21:05, Dave Carey wrote: > Hi Hans, > > Confirmed: on the YB9, both lenovo-ymc and yb9-kbdock register input > nodes with SW_TABLET_MODE in their capability bitmap (SW=2 in > /proc/bus/input/devices). You are right that this is a problem > regardless of which one fires events -- GNOME reads the capability at > startup. > > The recommended fix would be: add a DMI blocklist to lenovo_ymc_probe() > to return early on the Yoga Book 9, matching on: > > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > DMI_MATCH(DMI_PRODUCT_NAME, "83KJ"), > > That leaves yb9-kbdock as the sole SW_TABLET_MODE source on this > hardware. Ack, that sounds like the right approach. > Two questions on how you'd like to proceed: > > 1. Should the lenovo-ymc fix come as a standalone patch, or would you > prefer a v6 2-patch series with the ymc change as patch 1/2 and the > kbdock driver as patch 2/2? I think a v6 series makes most sense, even if one of the patches is just an unmodified reposting of this v5. > 2. For the early return in probe(): you suggested "return 0" to avoid > WMI framework error messages. That requires a NULL guard in > lenovo_ymc_notify() since priv is never set in that path. Is that > the right approach, or would you prefer a different pattern? My bad, that should be -ENODEV, so that the driver does not count as being bound, while still suppressing errors from the caller of probe. That should avoid lenovo_ymc_notify() getting called. Assuming there is no other functionality in lenovo-ymc we care about ... Regards, Hans