From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE6BEC4708F for ; Wed, 2 Jun 2021 01:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0C4E61003 for ; Wed, 2 Jun 2021 01:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbhFBBJB (ORCPT ); Tue, 1 Jun 2021 21:09:01 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:3328 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbhFBBJA (ORCPT ); Tue, 1 Jun 2021 21:09:00 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FvrNV5vjwz1BH2h; Wed, 2 Jun 2021 09:02:34 +0800 (CST) Received: from dggema761-chm.china.huawei.com (10.1.198.203) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 2 Jun 2021 09:07:14 +0800 Received: from [10.174.178.46] (10.174.178.46) by dggema761-chm.china.huawei.com (10.1.198.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 2 Jun 2021 09:07:14 +0800 Subject: Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() To: Mathieu Poirier CC: , , , , References: <20210601083100.130776-1-chengzhihao1@huawei.com> <20210601152047.GA1759269@xps15> From: Zhihao Cheng Message-ID: <73c51d6a-50e1-a7da-1c6f-66fb397c82ef@huawei.com> Date: Wed, 2 Jun 2021 09:07:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20210601152047.GA1759269@xps15> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggema761-chm.china.huawei.com (10.1.198.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/1 23:20, Mathieu Poirier дµÀ: > On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote: > > @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev) > mem_names[i]); > pru->mem_regions[i].va = devm_ioremap_resource(dev, res); > if (IS_ERR(pru->mem_regions[i].va)) { > - dev_err(dev, "failed to parse and map memory resource %d %s\n", > - i, mem_names[i]); > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/ Thanks for reminding. Ignore this patch. >> ret = PTR_ERR(pru->mem_regions[i].va); >> return ret; >> } >> -- >> 2.31.1 >> > .