From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D7E149AA34 for ; Fri, 2 Oct 2026 14:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790950481; cv=none; b=o441muxK1OFE6VW8iXofG8O7WqN+NQnPjGP6FZMfWGxY5w+MLNHUc3XkpxfmZic5GNndwbNwb6LmAnJbv3sW5KKnVC/PZLZUjFR2hb15qKZ1U9RO5IiKPATeGQR2XChsL8Wz/Mvs4OFakK+Hv6DFLV2UJkpGF23T4lVK8ohAEKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790950481; c=relaxed/simple; bh=j52YBQvyhm0qnm4xjwmBVEnjBVrMPDC8lohQo+T5vLg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=un+fGBruqCdbAw2+g+mhPT+kDV5iPl7ALseI9Eb9HcUT3ajFiXDcfCx56bCtBfml/CSeOds+aNN/vls156H3ppzWym2dko7JTQOYQN0lBVEuQB8B+YhAYVCssZQCOQohnk1V6224LLDw0yJpPOktnZIoTnZ56tCi4+72fV/3ix4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=SSv/2CMn; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="SSv/2CMn" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EFCC497; Fri, 2 Oct 2026 07:14:35 -0700 (PDT) Received: from [10.0.129.26] (e122027.cambridge.arm.com [10.0.129.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9C353F86F; Fri, 2 Oct 2026 07:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1790950478; bh=j52YBQvyhm0qnm4xjwmBVEnjBVrMPDC8lohQo+T5vLg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SSv/2CMn9K++VWgh78IGljwuILd5KO4eYt8+l6kpBl/pQuGDMTq6cwTkFXdVP9X6z 7wMcsqH2Vcn8AQsT8y1xvZJZ0QojYnmN0NMZUkr56tAZqLAim37u9OTjMusaz7sKSl IxlG4GOiJCY9JEeFu+9zL/pQIqDtzxI/GnSKhUeQ= Message-ID: <73c68c98-5ef3-44e1-81b8-16de37cf10ee@arm.com> Date: Fri, 2 Oct 2026 15:14:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 04/15] drm/panfrost: Skip NULL checks for clock enable/disabling To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , Boris Brezillon , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , Neil Armstrong References: <20260929-claude-fixes-v12-0-62beb08de207@collabora.com> <20260929-claude-fixes-v12-4-62beb08de207@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260929-claude-fixes-v12-4-62beb08de207@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 29/09/2026 04:44, Adrián Larumbe wrote: > The clk_* API can deal with NULL clock objects, so we can do away with NULL > checks in client code. > > Reviewed-by: Boris Brezillon > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_device.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c > index 5bf528f41278..b3a53504bd01 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_device.c > +++ b/drivers/gpu/drm/panfrost/panfrost_device.c > @@ -510,11 +510,9 @@ static int panfrost_device_resume(struct device *dev) > if (ret) > goto err_clk; > > - if (pfdev->bus_clock) { > - ret = clk_enable(pfdev->bus_clock); > - if (ret) > - goto err_bus_clk; > - } > + ret = clk_enable(pfdev->bus_clock); > + if (ret) > + goto err_bus_clk; > } > > ret = pm_runtime_force_resume(dev); > @@ -524,7 +522,7 @@ static int panfrost_device_resume(struct device *dev) > return 0; > > err_resume: > - if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS) && pfdev->bus_clock) > + if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) > clk_disable(pfdev->bus_clock); > err_bus_clk: > if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) > @@ -545,9 +543,7 @@ static int panfrost_device_suspend(struct device *dev) > return ret; > > if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { > - if (pfdev->bus_clock) > - clk_disable(pfdev->bus_clock); > - > + clk_disable(pfdev->bus_clock); > clk_disable(pfdev->clock); > } > >