From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Michael Dege <michael.dege@renesas.com>,
Christian Mardmoeller <christian.mardmoeller@renesas.com>,
Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH] net: phy: phy_ethtool_ksettings_set: Allow any supported speed
Date: Mon, 2 Dec 2024 14:20:17 +0500 [thread overview]
Message-ID: <73ca1492-d97b-4120-b662-cc80fc787ffd@cogentembedded.com> (raw)
In-Reply-To: <20241202100334.454599a7@fedora.home>
Hello.
> What's your use-case to need >1G fixed-settings link ?
My hardware is Renesas VC4 board (based on Renesas S4 SoC), network driver is rswitch, PHY in question
is Marvell 88Q3344 (2.5G Base-T1).
To get two such PHYs talk to each other, one of the two has to be manually configured as slave.
(e.g. ethtool -s tsn0 master-slave forced-slave).
This gets handled via driver's ethtool set_link_ksettings method, which is currently set to
phy_ethtool_ksettings_set().
Writing a custom set_link_ksettings method just to not error out when speed is 2500 looks ugly.
Nikita
next prev parent reply other threads:[~2024-12-02 9:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 8:33 Nikita Yushchenko
2024-12-02 9:03 ` Maxime Chevallier
2024-12-02 9:20 ` Nikita Yushchenko [this message]
2024-12-02 9:59 ` Maxime Chevallier
2024-12-02 10:10 ` Russell King (Oracle)
2024-12-02 10:17 ` Nikita Yushchenko
2024-12-02 10:23 ` Russell King (Oracle)
2024-12-02 11:09 ` Nikita Yushchenko
2024-12-02 12:30 ` Russell King (Oracle)
2024-12-02 15:51 ` Nikita Yushchenko
2024-12-02 16:03 ` Russell King (Oracle)
2024-12-03 11:01 ` Nikita Yushchenko
2024-12-03 15:15 ` Russell King (Oracle)
2024-12-03 14:05 ` Dennis Ostermann
2024-12-03 14:45 ` Andrew Lunn
2024-12-03 15:21 ` Russell King (Oracle)
2024-12-03 15:51 ` Maxime Chevallier
2024-12-03 16:37 ` Russell King (Oracle)
2024-12-02 14:32 ` Andrew Lunn
2024-12-02 10:03 ` Russell King (Oracle)
2024-12-03 14:02 ` Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ca1492-d97b-4120-b662-cc80fc787ffd@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=christian.mardmoeller@renesas.com \
--cc=davem@davemloft.net \
--cc=dennis.ostermann@renesas.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®