mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Martin Kurbanov <mmkurbanov@salutedevices.com>,
	Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
	Cheng Ming Lin <chengminglin@mxic.com.tw>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	Andreas Gnau <andreas.gnau@iopsys.eu>
Subject: Re: [PATCH RESEND v5 3/3] mtd: spinand: repeat reading in regular mode if continuous reading fails
Date: Fri, 30 Oct 2026 10:37:25 +0300	[thread overview]
Message-ID: <73cc1302-d1fa-4c32-b6ed-4c44cd48ad39@iopsys.eu> (raw)
In-Reply-To: <87mrrwebxh.fsf@bootlin.com>

Hi Miquel,
I think spi-mem capability for continuous read support is the best
solution.

On 10/29/26 18:58, Miquel Raynal wrote:
> Hi Mikhail,
>
> On 18/09/2025 at 00:54:01 +03, Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu> wrote:
>
>> Continuous reading may result in multiple flash pages reading in one
>> operation. Unfortunately, not all spinand controllers support such
>> large reading. They will read less data. Unfortunately, the operation
>> can't be continued.
>>
>> In this case:
>>  * disable continuous reading on this (not good enough) spi controller
>>  * repeat reading in regular mode.
>>
>> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> This patch unfortunately breaks continuous reads on my boards without
> dirmap support. The fact that they do not have dirmap support does not
> mean they are not capable of keeping CS asserted, these are two
> orthogonal hardware capabilities and it seems that we cannot easily
> discover it at run time.
>
> I recently had a similar issue with a "powerful" controller
> (cadence-qspi) with dirmap support. The fact that controllers will or
> will not spuriously assert their chip select is not discoverable
> either. As a result I created a spi-mem capability to flag this
> impossibility, which disables continuous reads. I will send a patch to
> revert this commit (keeping the previous ones) and another one to flag
> the Airoha controller as not having full control over its CS.
>
> Thanks,
> Miquèl

  reply	other threads:[~2026-10-30  7:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 21:53 [PATCH RESEND v5 0/3] mtd: spinand: fix continuous reading mode support Mikhail Kshevetskiy
2025-09-17 21:53 ` [PATCH RESEND v5 1/3] mtd: spinand: fix direct mapping creation sizes Mikhail Kshevetskiy
2025-09-17 21:54 ` [PATCH RESEND v5 2/3] mtd: spinand: try a regular dirmap if creating a dirmap for continuous reading fails Mikhail Kshevetskiy
2025-09-17 21:54 ` [PATCH RESEND v5 3/3] mtd: spinand: repeat reading in regular mode if " Mikhail Kshevetskiy
2026-10-29 15:58   ` Miquel Raynal
2026-10-30  7:37     ` Mikhail Kshevetskiy [this message]
2026-10-30  8:51       ` Miquel Raynal
2025-09-18  8:26 ` [PATCH RESEND v5 0/3] mtd: spinand: fix continuous reading mode support Miquel Raynal
2025-09-18 12:08   ` Mikhail Kshevetskiy
2025-09-29 15:53 ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2025-09-04 14:18 Mikhail Kshevetskiy
2025-09-04 14:18 ` [PATCH RESEND v5 3/3] mtd: spinand: repeat reading in regular mode if continuous reading fails Mikhail Kshevetskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73cc1302-d1fa-4c32-b6ed-4c44cd48ad39@iopsys.eu \
    --to=mikhail.kshevetskiy@iopsys.eu \
    --cc=Takahiro.Kuwano@infineon.com \
    --cc=andreas.gnau@iopsys.eu \
    --cc=chengminglin@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mmkurbanov@salutedevices.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®