From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADABFC352BE for ; Thu, 16 Apr 2020 19:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AECB20786 for ; Thu, 16 Apr 2020 19:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="QM5X6cMe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729457AbgDPTCS (ORCPT ); Thu, 16 Apr 2020 15:02:18 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:24965 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728250AbgDPTCQ (ORCPT ); Thu, 16 Apr 2020 15:02:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587063735; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=QHkedZEwWQEVeZsqvvOLG0I8Dhpk5m6hlvwQ9hGoh0A=; b=QM5X6cMe9LTkzJRp8TPgTh108VQBF++IZH50T2NsJpT7tiVWIEEsPm1C+52TNO540Y3QGixO 5SLmmotaZ3DodV9ydjLMRwvH1zrR3N1JTLY9gO1MsOJ4SZKciSyI79uwzISANNtoZYqWiuzc dwGQbCcMvUOLXXz0ThIdnzae4T4= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e98ab8b.7f4c067a4420-smtp-out-n04; Thu, 16 Apr 2020 19:01:31 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9262BC433F2; Thu, 16 Apr 2020 19:01:31 +0000 (UTC) Received: from [10.46.162.249] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemantk) by smtp.codeaurora.org (Postfix) with ESMTPSA id E66AFC433CB; Thu, 16 Apr 2020 19:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E66AFC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=hemantk@codeaurora.org Subject: Re: [PATCH 1/2] bus: mhi: core: Fix parsing of mhi_flags To: Manivannan Sadhasivam , "jhugo@codeaurora.org; dan.carpenter"@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, smohanad@codeaurora.org, dan.carpenter@oracle.com References: <20200413120741.2832-1-manivannan.sadhasivam@linaro.org> From: Hemant Kumar Message-ID: <73d4815e-af00-e4cd-95c5-5043d334224c@codeaurora.org> Date: Thu, 16 Apr 2020 12:01:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200413120741.2832-1-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, On 4/13/20 5:07 AM, Manivannan Sadhasivam wrote: > With the current parsing of mhi_flags, the following statement always > return false: > > eob = !!(flags & MHI_EOB); > > This is due to the fact that 'enum mhi_flags' starts with index 0 and we > are using direct AND operation to extract each bit. Fix this by using > BIT() macro to extract each bit and make the mhi_flags index start from 1. > > Fixes: 189ff97cca53 ("bus: mhi: core: Add support for data transfer") > Reported-by: Dan Carpenter > Signed-off-by: Manivannan Sadhasivam > --- > drivers/bus/mhi/core/main.c | 6 +++--- > include/linux/mhi.h | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index eb4256b81406..4165a853c189 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -1090,9 +1090,9 @@ int mhi_gen_tre(struct mhi_controller *mhi_cntrl, struct mhi_chan *mhi_chan, > if (ret) > return ret; > > - eob = !!(flags & MHI_EOB); > - eot = !!(flags & MHI_EOT); > - chain = !!(flags & MHI_CHAIN); > + eob = !!(flags & BIT(0)); > + eot = !!(flags & BIT(1)); > + chain = !!(flags & BIT(2)); How about setting enums  with BIT macro and still use same enums above. If flags is having MHI _CHAIN (enum value 3) but comparing with BIT(2) (value 4) will not work. > bei = !!(mhi_chan->intmod); > > mhi_tre = tre_ring->wp; > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index ad1996001965..22185fecbbf2 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -53,7 +53,7 @@ enum mhi_callback { > * @MHI_CHAIN: Linked transfer > */ > enum mhi_flags { > - MHI_EOB, > + MHI_EOB = 1, > MHI_EOT, > MHI_CHAIN, > }; enum mhi_flags {     MHI_EOB = BIT(0),     MHI_EOT = BIT(1),     MHI_CHAIN = BIT(2), } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project