From: Bean Huo <huobean@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Can Guo <cang@codeaurora.org>,
Stanley Chu <stanley.chu@mediatek.com>
Subject: Re: [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset()
Date: Wed, 04 Nov 2020 09:44:27 +0100 [thread overview]
Message-ID: <73d4aff5c11424cf2f18735804a6cffccba07cad.camel@gmail.com> (raw)
In-Reply-To: <20201103141403.2142-3-adrian.hunter@intel.com>
On Tue, 2020-11-03 at 16:14 +0200, Adrian Hunter wrote:
> It is simpler for drivers to provide a ->device_reset() callback
> irrespective of whether the GPIO, or firmware interface necessary to
> do the
> reset, is discovered during probe.
>
> Change ->device_reset() to return an error code. Drivers that
> provide
> the callback, but do not do the reset operation should return
> -EOPNOTSUPP.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Bean huo <beanhuo@micron.com>
next prev parent reply other threads:[~2020-11-04 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:14 [PATCH V4 0/2] scsi: ufs: Add DeepSleep feature Adrian Hunter
2020-11-03 14:14 ` [PATCH V4 1/2] " Adrian Hunter
2020-11-04 8:04 ` Can Guo
2020-11-04 8:29 ` Can Guo
2020-11-04 8:37 ` Adrian Hunter
2020-11-04 9:03 ` Can Guo
2020-11-04 10:57 ` Bean Huo
2020-11-04 11:55 ` Adrian Hunter
2020-11-04 13:19 ` Bean Huo
2020-11-04 16:35 ` Asutosh Das (asd)
2020-11-05 1:42 ` Stanley Chu
2020-11-03 14:14 ` [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset() Adrian Hunter
2020-11-04 2:55 ` Stanley Chu
2020-11-04 8:05 ` Can Guo
2020-11-04 8:44 ` Bean Huo [this message]
2020-11-04 16:35 ` Asutosh Das (asd)
2020-11-05 4:06 ` [PATCH V4 0/2] scsi: ufs: Add DeepSleep feature Martin K. Petersen
2020-11-11 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d4aff5c11424cf2f18735804a6cffccba07cad.camel@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome