From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC33239D6FD for ; Fri, 22 May 2026 05:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428430; cv=none; b=WSouo1yIhGZpERnzD1CI/t1GdVky2RobMmkxWGSPd2XqOcaHk7uU9OVlDzBjqvEgVacHBBPLViBVDU9KXKD0itox/utcjorZHu+POhc0ipCrG78n9vTRlPCmStGgbUxOBbRGG0AcE+zY7RcU4O74MYcg/smemvKngojQlR5kATk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428430; c=relaxed/simple; bh=0cPudROcNvFUmJnOoptTXlofQ0YAHPJEaiTCOFtv/iQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UULmtlKR6KNjAdP3geXc9yxGZiVAKsRUnVk5Rx/HYAJ3rVRc9Q8ksywXezVmOD+Ju5jVwzrs1+h8UriJwilOtYj/JUg83G0ePEJnGCrr3u729o9Aqn37FwvVkF4bmSyahnnyzoV0FElnnM80FGBDyF8LC/bqauTf79AbOGvMf6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IzZr0hZj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RKcZNpJe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IzZr0hZj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RKcZNpJe" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M41QN01816077 for ; Fri, 22 May 2026 05:40:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ngxnF0u9afi5oKExZod7l9Sw9Qq4rEIs2c7zolCqfWI=; b=IzZr0hZj+g/7eYVD 5b0HwPyCdVZ02Zj9+N8LwInc3H5OSHBatPiAoa2q0Jc1VvotLtklzZJ8bT1Li91D IxoP4wGLC/y4AFsoyvzcvOHoq6z6g/p22EcpBVzO9ZYGHaMZuiRieyG37rk1zepq 37kzYREDgyTPgwAC/Y8SINDjeCM8m3jRAAgVoTWMumEBJBKEqNUp/rzACjGr3dHz 615moKUjwt1NlYooBmKUtrIXaohEM8hVeavCvr0v38jFMJy1HUVUbJ9kYQRqjWSJ w6KzE6WQtOcVZxpDhwLn7FmlO5DehFFkgJuKBUWrt8OlLrHRj+2dYsDgUtIh4et1 Q52x6w== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrm08qy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 05:40:27 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2bd04e4fe3dso127178625ad.3 for ; Thu, 21 May 2026 22:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779428427; x=1780033227; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ngxnF0u9afi5oKExZod7l9Sw9Qq4rEIs2c7zolCqfWI=; b=RKcZNpJehPJh6wAB1BfG9PrYPhB6C9cRTwdj63VFbJKM6485kRO0MXgNfPz22/xYQq WW+5SwqddtFPv96sG7hyulLvk5nBeXMLK+p2nvabRExpFzbGLzp/bStb8aEVJUg4YerG AUrryHSDAQuzSFZL4jhEpJvRDx3oYEAt6VnDHmO+gYx6VcgKTwHI+ufw6kGyZo4RxhVx ZYS1EVgLcSqtZtTzGOCljDxsmpKUPGmecInnSXiudcJeLVAJK1I7YPeTTkgYBA1Gh7ad TvkKSY7AJ5o+Xmmgjj8YBrbv/b9KegWwFpKB9VCBr04nMiI8m02jdijksilc1BdFigNU T8EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779428427; x=1780033227; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ngxnF0u9afi5oKExZod7l9Sw9Qq4rEIs2c7zolCqfWI=; b=oZU6EGX+1xuuak3rKr/K3ByJUEUHzE9aKW1d0O1oA8ChhGFVHv+jOtZDLd/fC253WH dJvArYgt4ME3vERYjbVFhCPj7dR2Of6BTc9xopBYTWrHVGszOQzyFWB/xbgw4QVPfIAB OfkWsWA9xdpJRf0f6iBeD6qeoL3/AindBXZ30WJw/D2GnNhAitzVFk3kImNnfovxj5d+ 5XsSgRP3yjBRd1tzEmFzuABqV/gLL3iJWHyjeIQ7pn5AzeD0yRGn+JJQeD24PeWp5J88 hQMfyz3gCRXO32oHwn5RLVarTX2TK7C0QRe3BjPRVtr6N96hLqjXCOkrD5LErG1d5PiW NxOw== X-Forwarded-Encrypted: i=1; AFNElJ/FBII7megcv0cHs9xtTLi2OtKvsXD4lky6VmbzcnJnDzkl84/CYMc6wkAnMAowbwFnmQ5mH7r2+VYY+0M=@vger.kernel.org X-Gm-Message-State: AOJu0YxUGuIxYMn6dEikmUVsALGNW/Fa86HCPH421UFURdXayPVHRtbY RJGRs38pYUDec9hVt0y+Bhwd1lifNcMF3iXFwVOKFrWSQcO0qI9qik/Yj53JccLX2k29yKjkIYN Ymj9zHAZ/593T1XOJATXvnCEQdkTHwmYoXeB8OzcwJm2vLL65IsRybAQyHKOjMps5q/s= X-Gm-Gg: Acq92OElXM82BjuwRlOf+Uxbg3JjUlnpexR+6GbU1jZzkjTYb7fpZpXPzitfebepwr+ hROY7CG3rI/8MtXNbex29FFdgPqf/741evLyhhgGYM7dc14ZTuswTCuaBFwa9g5Ww0tPIqoY9pn /zjWTL6mQMDSLyHs+vrsega0khFmOHI4UWin4tvUS8r58saH0N4TaoI4jyi2JooQhc5ihtS8A76 qzS5vgDa4sbimPIQcrwrbv4xo2PbqLPDtYIsWEWSbsU65rQV8hV3OdgaTP1ym6eB7AoE7GP9QiI /I58rtKqvXEzXUzc/lt/BohgzoyRBJ8xEvwqZ36lRab6oC+mG9emggeBdlLuC6EBRRiEQXZ/3mr xWLL1CxMLOKpKf7YgNxf3d41p7XbthgUkwhIR0fer3gzCKruJL8QLiGC5U9FX97vmGMBZ/LBtnw j107TZwZm6G0dT/AUz+w== X-Received: by 2002:a17:902:e88e:b0:2ba:6ca2:bd9 with SMTP id d9443c01a7336-2beb07032fbmr22494355ad.41.1779428426724; Thu, 21 May 2026 22:40:26 -0700 (PDT) X-Received: by 2002:a17:902:e88e:b0:2ba:6ca2:bd9 with SMTP id d9443c01a7336-2beb07032fbmr22494065ad.41.1779428426246; Thu, 21 May 2026 22:40:26 -0700 (PDT) Received: from [10.133.33.151] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb5695b2esm4120785ad.4.2026.05.21.22.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 22:40:25 -0700 (PDT) Message-ID: <73d4fac8-9b49-4872-807f-8a69219aee7a@oss.qualcomm.com> Date: Fri, 22 May 2026 13:40:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 3/3] cpufreq: conservative: Simplify frequency limit handling To: Viresh Kumar , "Rafael J. Wysocki" , Stratos Karafotis Cc: linux-pm@vger.kernel.org, Vincent Guittot , Sumit Semwal , Lifeng Zheng , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, zhongqiu.han@oss.qualcomm.com References: <292e6d937890f135e30ec0d2107eaad47cb9a976.1779423281.git.viresh.kumar@linaro.org> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <292e6d937890f135e30ec0d2107eaad47cb9a976.1779423281.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: TZAUzCpV0imSU-xUcphylsiqIHOaKwRI X-Authority-Analysis: v=2.4 cv=Zekt8MVA c=1 sm=1 tr=0 ts=6a0fec4b cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=i0EeH86SAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=xinJjMVPPjMSk5ikLX4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA1MyBTYWx0ZWRfX6pv2mo82fJZg GuktvWYANvZ13ar7lgMghyZkN6qvR9CINTWvDTNktUu/hE3E6+xsbR4EEx5qcrJpt/NCKk1q5gC FMbe5rrI9qhmF5sSDs9kiCSvKY6hUeBYkreoRE/JDHUYovMIFziuMfIzwqgHPS5tNaC8ZgDSir7 0oj+d59UUaRzt2qkkbBDpha1/bwh4AAO/LrplU58NdXlc1UppGQtNxSTpTIbCj48SIZ9TUW5ltb 9sbQYZWSeYF/ReT8TsKRHGoagreQBEpFH8W3e5HrbzRYhqqRFHYZ6przVONdp1ZFzKzeTNFwVaf vMywnQ/15sp1ZlFBYdk/RXPfqE3S5x56SZh+rhGPsVUm3JO+F394+33ZEIKXylFeFJsI2pl7tzy AzsA4Aq9/JdEZXBQ1p2A6bY05cMCrkY29E/DTwdD0QRhUgLfEqT6sb0NkiosMlfVZ1vgnZ0bgP3 bOaX1KLMnRBGBbHncPA== X-Proofpoint-GUID: TZAUzCpV0imSU-xUcphylsiqIHOaKwRI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220053 On 5/22/2026 12:19 PM, Viresh Kumar wrote: > From: Lifeng Zheng > > cs_dbs_update() performs explicit checks against policy->min/max > before updating the target frequency. These checks are redundant as > __cpufreq_driver_target() already clamps the requested frequency to > the valid policy limits. > > Remove the unnecessary boundary checks and simplify the update logic. > > This also fixes an issue introduced by commit 00bfe05889e9 ("cpufreq: > conservative: Decrease frequency faster for deferred updates"), where > stale target comparisons could cause frequency updates to be skipped > entirely after deferred adjustments. > > Closes: https://lore.kernel.org/all/20260421123545.1745998-1-zhenglifeng1@huawei.com/ > Fixes: 00bfe05889e9 ("cpufreq: conservative: Decrease frequency faster for deferred updates") > Signed-off-by: Lifeng Zheng > Co-developed-by: Viresh Kumar > Signed-off-by: Viresh Kumar Thanks Viresh and Lifeng, this looks good to me. Reviewed-by: Zhongqiu Han > --- > drivers/cpufreq/cpufreq_conservative.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c > index df01d33993d8..0b32ae28ec85 100644 > --- a/drivers/cpufreq/cpufreq_conservative.c > +++ b/drivers/cpufreq/cpufreq_conservative.c > @@ -103,10 +103,6 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy) > if (load > dbs_data->up_threshold) { > dbs_info->down_skip = 0; > > - /* if we are already at full speed then break out early */ > - if (requested_freq == policy->max) > - goto out; > - > requested_freq += freq_step; > if (requested_freq > policy->max) > requested_freq = policy->max; > @@ -124,13 +120,7 @@ static unsigned int cs_dbs_update(struct cpufreq_policy *policy) > > /* Check for frequency decrease */ > if (load < cs_tuners->down_threshold) { > - /* > - * if we cannot reduce the frequency anymore, break out early > - */ > - if (requested_freq == policy->min) > - goto out; > - > - if (requested_freq > freq_step) > + if (requested_freq > policy->min + freq_step) > requested_freq -= freq_step; > else > requested_freq = policy->min; -- Thx and BRs, Zhongqiu Han