From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
florian.fainelli@broadcom.com, heiko.stuebner@cherry.de,
frank.li@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v4 net] net: phy: micrel: Dynamically control external clock of KSZ PHY
Date: Fri, 13 Dec 2024 11:44:34 +0100 [thread overview]
Message-ID: <73d5ea2b-8cec-46e9-80a9-a7a96657c2d4@lunn.ch> (raw)
In-Reply-To: <20241211072136.745553-1-wei.fang@nxp.com>
> To solve this problem, the clock is enabled when phy_driver::resume() is
> called, and the clock is disabled when phy_driver::suspend() is called.
> Since phy_driver::resume() and phy_driver::suspend() are not called in
> pairs, an additional clk_enable flag is added. When phy_driver::suspend()
> is called, the clock is disabled only if clk_enable is true. Conversely,
> when phy_driver::resume() is called, the clock is enabled if clk_enable
> is false.
This is what i don't like too much, the fact suspend/resume is not
called in pairs. That was probably a bad decision on my part, and
maybe it should be revised. But that is out of scope for this patch,
unless you want the challenge.
> +static int ksz8041_resume(struct phy_device *phydev)
> +{
> + struct kszphy_priv *priv = phydev->priv;
> +
> + kszphy_enable_clk(priv);
> +
> + return 0;
> +}
> +
> +static int ksz8041_suspend(struct phy_device *phydev)
> +{
> + struct kszphy_priv *priv = phydev->priv;
> +
> + kszphy_disable_clk(priv);
> +
> + return 0;
> +}
These two look odd. Why is there no call to
genphy_suspend/genphy_resume? Probably a comment should be added here.
> @@ -2150,8 +2198,11 @@ static int ksz9477_resume(struct phy_device *phydev)
>
> static int ksz8061_resume(struct phy_device *phydev)
> {
> + struct kszphy_priv *priv = phydev->priv;
> int ret;
>
> + kszphy_enable_clk(priv);
> +
> /* This function can be called twice when the Ethernet device is on. */
> ret = phy_read(phydev, MII_BMCR);
> if (ret < 0)
What about 8061_suspend()? They normally are used in pairs.
> @@ -2221,6 +2272,11 @@ static int kszphy_probe(struct phy_device *phydev)
> return PTR_ERR(clk);
> }
>
> + if (!IS_ERR_OR_NULL(clk)) {
> + clk_disable_unprepare(clk);
> + priv->clk = clk;
> + }
I think you should improve the error handling. If
devm_clk_get_optional_enabled() returns an error, you should fail the
probe. If the clock does not exist, devm_clk_get_optional_enabled()
will return a NULL pointer, which is a valid clock. You can
enable/disable it etc. So you then do not need this check.
> +static int lan8804_suspend(struct phy_device *phydev)
> +{
> + struct kszphy_priv *priv = phydev->priv;
> + int ret;
> +
> + ret = genphy_suspend(phydev);
> + if (ret)
> + return ret;
> +
> + kszphy_disable_clk(priv);
> +
> + return 0;
> +}
> +
> +static int lan8841_resume(struct phy_device *phydev)
> +{
> + struct kszphy_priv *priv = phydev->priv;
> +
> + kszphy_enable_clk(priv);
> +
> + return genphy_resume(phydev);
> +}
> +
> static int lan8841_suspend(struct phy_device *phydev)
> {
> struct kszphy_priv *priv = phydev->priv;
> struct kszphy_ptp_priv *ptp_priv = &priv->ptp_priv;
> + int ret;
>
> if (ptp_priv->ptp_clock)
> ptp_cancel_worker_sync(ptp_priv->ptp_clock);
>
> - return genphy_suspend(phydev);
> + ret = genphy_suspend(phydev);
> + if (ret)
> + return ret;
> +
> + kszphy_disable_clk(priv);
> +
> + return 0;
This can be simplified to
return lan8804_suspend(phydev);
In general, you should define a common low level function which does
what all PHYs need, in this case, genphy_suspend() and disable the
clock. Then add wrappers which do additional things.
Andrew
next prev parent reply other threads:[~2024-12-13 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 7:21 Wei Fang
2024-12-12 15:06 ` Jakub Kicinski
2024-12-13 10:44 ` Andrew Lunn [this message]
2024-12-16 2:29 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d5ea2b-8cec-46e9-80a9-a7a96657c2d4@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=frank.li@nxp.com \
--cc=heiko.stuebner@cherry.de \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®