Re: [PATCH 1/2] dt-bindings: hwmon: Add mps mpm369x driver bindings

[Guenter Roeck <linux@roeck-us.net>]

On 3/18/26 01:02, Guenter Roeck wrote:
> On 3/18/26 00:02, Yuxi Wang wrote:
>> Add a device tree bindings for mpm369x device family,
>> which includes mpm3695-20 and mpm3690S-15.
>>
>> Signed-off-by: Yuxi Wang <Yuxi.Wang@monolithicpower.com>
>> ---
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index a482aeadcd44..7b9d9bc89d07 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -342,6 +342,10 @@ properties:
>>               # Monolithic Power Systems Inc. digital step-down converter mp9945
>>             - mps,mp9945
>>               # Temperature sensor with integrated fan control
>> +          - mps,mpm3695-20
>> +            # Monolithic Power Systems Inc. multi-phase controller mpm3695-20
>> +          - mps,mpm3690S-15
>> +            # Monolithic Power Systems Inc. multi-phase controller mpm3690S-15
> 
> Each of the series supports several power levels,
> indicated by the -xx extension.
> 
> For the most part, the chip variants are register compatible, with few exceptions.
> Specifying the extension in the devicetree compatible string therefore does
> no make sense unless really needed.
> 

Also, please note that mps,mpm3695 is already documented in
Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml.
MPM3690 and its variants should be listed there as well.
At least one of those (MPM3690-50D) also supports PMBus.

Thanks,
Guenter