From: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
To: "Birk Skyum" <birk.skyum@pm.me>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel J Blueman <daniel@quora.org>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
linux-arm-msm@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/2] Monitor Yoga Slim 7x EC sensors without taking over cooling
Date: Tue, 15 Sep 2026 14:53:24 +0530 [thread overview]
Message-ID: <73db10fb-7778-44be-aced-562aa1039404@oss.qualcomm.com> (raw)
In-Reply-To: <20260908135801.81436-1-birk.skyum@pm.me>
On 9/8/2026 7:28 PM, Birk Skyum wrote:
> Two design questions for this RFC:
> - Is this read-only match-data path the preferred way to accommodate
> the Lenovo firmware alongside the reference-board work?
The read-only match-data path looks fine, but it should be integrated
with the existing LUT match data. We should not replace the current
match-data usage.
> - Should the pending Lenovo binding omit the qcom,hamoa-crd-ec fallback,
> given that this firmware cannot satisfy the reference driver's probe?
If this firmware cannot pass the reference-board thermal-capability
probe, I think the Lenovo binding should not use qcom,hamoa-crd-ec as a
fallback. The fallback should be used only if the device is functionally
compatible with the reference-board driver, not only because it uses the
same EC chip.
In that case, the binding changes in Daniel’s patch also need to be updated.
--
Best Regards,
Anvesh
next prev parent reply other threads:[~2026-09-15 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:58 Birk Skyum
2026-09-08 13:58 ` [RFC PATCH v2 1/2] platform: arm64: qcom-hamoa-ec: monitor Slim 7x legacy sensors Birk Skyum
[not found] ` <20260908140849.229ED1F00A3A@smtp.kernel.org>
2026-09-08 14:36 ` Birk Skyum
2026-09-09 4:58 ` Anvesh Jain P
2026-09-15 9:28 ` Anvesh Jain P
2026-09-08 13:58 ` [RFC PATCH v2 2/2] platform: arm64: qcom-hamoa-ec: test sensor and variant handling Birk Skyum
2026-09-15 9:23 ` Anvesh Jain P [this message]
2026-09-15 14:17 ` [RFC PATCH v2 0/2] Monitor Yoga Slim 7x EC sensors without taking over cooling Birk Skyum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73db10fb-7778-44be-aced-562aa1039404@oss.qualcomm.com \
--to=anvesh.p@oss.qualcomm.com \
--cc=birk.skyum@pm.me \
--cc=bryan.odonoghue@linaro.org \
--cc=corbet@lwn.net \
--cc=daniel@quora.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maccraft123mc@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®