mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Lars Povlsen" <lars.povlsen@microchip.com>,
	"Steen Hegelund" <Steen.Hegelund@microchip.com>,
	"Clément Léger" <clement.leger@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Kavyasree Kotagiri" <kavyasree.kotagiri@microchip.com>
Subject: Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a module"
Date: Wed, 13 Jul 2022 11:03:40 +0200	[thread overview]
Message-ID: <73dc6fcedebcae098751bd093fe2d028@walle.cc> (raw)
In-Reply-To: <20220713084010.168720-1-p.zabel@pengutronix.de>

[+ Claudiu, Kavyasree ]
Am 2022-07-13 10:40, schrieb Philipp Zabel:
> This reverts commit b6b9585876da018bdde2d5f15d206a689c0d70f3.
> 
> This breaks MDIO on kswitch-d10, presumably because the global switch
> reset is not released early enough anymore.
> 
> Reported-by: Michael Walle <michael@walle.cc>
> Cc: Clément Léger <clement.leger@bootlin.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Thanks!

Tested-by: Michael Walle <michael@walle.cc>

And maybe Microchip can chime in here and tell us what
subsystems in the SoC will actually be reset by this.
I fear this reset will affect almost every part of the
SoC. So it would have to be bound to every single
device? Or maybe adding that reset to the switch driver
was a mistake in the first place?

I mean, if it wouldn't be for the guard bit, it would
also reset the CPU core..

-michael

  reply	other threads:[~2022-07-13  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  8:40 Philipp Zabel
2022-07-13  9:03 ` Michael Walle [this message]
2022-07-13  9:40   ` Steen Hegelund
2022-07-13  9:52     ` Michael Walle
2022-07-13 12:08       ` Philipp Zabel
2022-08-04  7:53         ` Michael Walle
2022-08-09 10:19           ` Steen Hegelund
2022-08-09 10:27             ` Michael Walle
2022-08-26 11:37         ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73dc6fcedebcae098751bd093fe2d028@walle.cc \
    --to=michael@walle.cc \
    --cc=Steen.Hegelund@microchip.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=clement.leger@bootlin.com \
    --cc=kavyasree.kotagiri@microchip.com \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®