From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094C0EB64DA for ; Mon, 19 Jun 2023 07:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjFSH1d convert rfc822-to-8bit (ORCPT ); Mon, 19 Jun 2023 03:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjFSH10 (ORCPT ); Mon, 19 Jun 2023 03:27:26 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 253E6121; Mon, 19 Jun 2023 00:27:22 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 378B88138; Mon, 19 Jun 2023 15:27:14 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 19 Jun 2023 15:27:14 +0800 Received: from [192.168.1.218] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 19 Jun 2023 15:27:13 +0800 Message-ID: <73ded260-3967-7547-9317-f4cbe5bcbb1c@starfivetech.com> Date: Mon, 19 Jun 2023 15:27:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 3/6] media: starfive: Add basic driver Content-Language: en-US To: Bryan O'Donoghue , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia CC: , , , References: <20230525083202.67933-1-jack.zhu@starfivetech.com> <20230525083202.67933-4-jack.zhu@starfivetech.com> From: Jack Zhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bryan, Thank you for your comments. On 2023/6/16 21:13, Bryan O'Donoghue wrote: > On 25/05/2023 09:31, Jack Zhu wrote: >> Add basic platform driver for StarFive Camera Subsystem. >> >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Jack Zhu > > One thing here is the patch title and hence commit message. > > "media: starfive:" doesn't really tell you this is a camera versus say a encoder/decoder. > > I see you've used the name "camss" for your driver, which I think is a perfectly good and logical choice - however if you started to make commits along the lines of "media: camss" that would conflict with the qcom camss. > > How about for starfive and qcom by the way, we do what Laurent did in > > commit 3e8537b4c15172bfe1b285c3155ed5c37d523cd3 > Author: Laurent Pinchart > Date:   Wed Dec 21 10:33:39 2022 +0100 > >     media: ti: omap3isp: Use media_pipeline_for_each_entity() > > i.e. future StarFive commits for camera would be "media: starfive: camss" and similarly for Qualcomm "media: qualcomm: camss" > > The point being the commit title namespace should be instructive and specific re: 3e8537b4c15172bfe1b285c3155ed5c37d523cd3 > Okay， I will add a camss directory under the starfive directory and modify the patch title. > --- > bod -- Regards, Jack Zhu