From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271BC27D786 for ; Sat, 11 Jul 2026 02:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783738481; cv=none; b=hp7MV1xL7rus66Rg/X7bw01GdBcbPTLo7aJYHFHYMfYf5Oo+Xz3BgiH6Vhf7PcVTkDdxjr7lbvkrqrUNQ+KpUc8mHFxCYIc6wnkWa/I6KSqQvmDXoJXyAP2qXY0yoq8vZOme/o44MQQEJA0PDxm1vKEdHI4HoHApjuIFQ6ggczc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783738481; c=relaxed/simple; bh=e+5oTDlJE3JeVGw8kwraD9BnLZNaTeaClLqHopfsvpg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ThGasvk0BDKKu7Z6DYrgEpxpEHQd0zqLR1EE3ZuLgprBz5V425+HlY02gwNR+7CtlUmjSPycQyo1ffnnRZd1TTVDuUMrHW6Co8MRzA5+LjM97ctTx+6RF1V0W5T9W3TX8P2bRps4MxJ/POP+eId3tKKlgzvRRFl9q7h+Yy2+ctA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AaYX6Av8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TGxcB5cv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AaYX6Av8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TGxcB5cv" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66B29VWK2658217 for ; Sat, 11 Jul 2026 02:54:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J2+OHtFXDardG1nxZZRPnKNBAxjQeEXhfcwumgbzb4g=; b=AaYX6Av8yvYvaJ0j PjF9y9PlI6MKxkfvv3zTMKgG/+V8mJJpEBzjezQq02SAM7+g7rL95R3YSjAtcwXW Y9LyPpZnfKwqZS0YxQnRhJTLU9658HJtSZEFOJpIVDqv52c2ikA9lrOM+TtxhGA9 vzzte+HVfSHMgC/wPuT1m+UjKuxLM0vE9EdURBbXE7/Vgo1RoXk7UT2ZVD2I4UdS c8nnOqv9bYFWA1FZIKgoGSM+O+KN603LBw8IMKW4743bphihfb1RC8iWIkjXtP5h mSiGu9h1p4Xncwq2YIWKlVr1clYG48HWEczuy1mYidpNmoPvs4yrAMVQHqBcNum9 EEUDXw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbcssg29p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 11 Jul 2026 02:54:39 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c892143db7fso1437026a12.1 for ; Fri, 10 Jul 2026 19:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783738479; x=1784343279; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=J2+OHtFXDardG1nxZZRPnKNBAxjQeEXhfcwumgbzb4g=; b=TGxcB5cv8addLJROzvfzgAp5IYoOvsmXj7vq9KvTyxWDPfEQRrVpDuXygWIQMtGVbR eZ1oKLgadAUjVsbq7jlqN33OvBGUwjP4uV/f0JBKHxE5L5wJexH8O43OpV9zktTR9L21 JbibRlsTDzLaZoCHYXfm2cD2ILBdHWdDfh1mKV5XXOi/U9iKEMlqvifc/rNeRzh434nL 8kS8D+8pJaCkwuYGdmfJSkDPmOa+N81WCLjhythXBVVI6WRmx047Xd6WADyqsd3MCWMs ty5dpNAcQORfIYhhF4soOlLjgnzIItnhBHQgV0vhLdpSgff34ctiiAAeK/A54fAI+iiD rsJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783738479; x=1784343279; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J2+OHtFXDardG1nxZZRPnKNBAxjQeEXhfcwumgbzb4g=; b=XXFLsyJvXSLtkklQSWo1q9RM/GT93QfRlW7J1A/8X7d4UpSOEgrozJX9dmfpFjzpkx 5zxNaeWUMJ9ZPxeM3lOm0duOvLH/D7hYwEsBhNzGohuoAqOLEkDC8Vfd91dp3R/FWPa1 NpeCEx4PL3fQ5kI9MueBzTVkbECFWN+QoVOnPFx66sxruvB+kII531wql0mDBGEI+W/x mpzuRn23IAvj+4QPO1XIj825iJqOrx31MEhpTPpf/6XOk6wFQh+JwbOwMmFhQRkRhqsq LIRNRB2wNo6m7kSNHIGqyWWofnVkRg5lYlwg/PS7Mx9VZzMMkX2v0KJqWLbyqN7H2elR luFA== X-Forwarded-Encrypted: i=1; AHgh+Rqop95vf03HJHqjzw0YL08ZQ+CGLpxkXeg10bFZPm6Z7LkuujxYwPZohw50u3lJLYsV22LhwvtxWWCkddE=@vger.kernel.org X-Gm-Message-State: AOJu0YwQYNBzL9gKpxA7GhO7BhsiCp/zpS0gmegmU3n9lq7uRu5Q/Djj mUIUUmIldMJo4fqOcmlOndm5TUGjwqz+LKKMLAOi6RdGVgQVLjxz5C1DJKnAQ6jwLWvipEp8Iwd qD3RVsGeMrqRTjjHzMsQBKeBhvpZCkAF2bbQ3inu64WoS1WmQtbsB+iya8NAtfD9Udj0= X-Gm-Gg: AfdE7cnEnthEinLKtP8ut80/eDig+g8TwoyOGkPs/UA7metjN5Nz6R2u4LfXgDwvRDp xlkkdouEmUgFkEO1cWWCuWE/3g3vyayBWvTscSxOkpHq8TJnQBXXU5OdPUG0RWxogqpRAEdv3Qk OvKxqK0n8ownl1wOXJ1+j3yN2eQbEy/Q/uBl0uLPM+G3xI06kBk339KDWUeElfl7TRC/Ijb2n5J Sxl+PTf4wx1MZKd21lA2KyAJ8AtImF728QBQToKH3Lu2y2cZP7nVukXqDApZ8fV2fM03FNgjgwh Jdfe/SgRVa8OuT5saSO7ef0KYBxzYkeo4+/WB/vdYvJfI6FS178GGgbnDR2wNTjrj52gpTkWIO4 i1gUiMeo/DOnL45byYVjnrcBbLdY3ey4AZErYlRcd8Q== X-Received: by 2002:a05:6a20:4304:b0:3a2:f75f:73ef with SMTP id adf61e73a8af0-3c110a65ba0mr1534083637.37.1783738478722; Fri, 10 Jul 2026 19:54:38 -0700 (PDT) X-Received: by 2002:a05:6a20:4304:b0:3a2:f75f:73ef with SMTP id adf61e73a8af0-3c110a65ba0mr1534062637.37.1783738478252; Fri, 10 Jul 2026 19:54:38 -0700 (PDT) Received: from [192.168.0.4] ([49.204.105.43]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b4b97661sm11787208eec.7.2026.07.10.19.54.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 19:54:37 -0700 (PDT) Message-ID: <73df1c58-39a3-4f89-8674-43fb2dc36a06@oss.qualcomm.com> Date: Sat, 11 Jul 2026 08:24:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] spi: qcom-geni: add GENI SE registers trace event on error paths To: Mark Brown Cc: Bjorn Andersson , Konrad Dybcio , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mukesh Kumar Savaliya , Konrad Dybcio References: <20260711-add-tracepoints-for-se-reg-dump-v2-0-ca1e9ba62359@oss.qualcomm.com> <20260711-add-tracepoints-for-se-reg-dump-v2-2-ca1e9ba62359@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzExMDAyNSBTYWx0ZWRfX7QtHE1yzBg4Z A7VYaPobC3GXzW30nNOD/OP5A3P+s+U8lceESjQUq4WvGl2s7lYT3Td4di1HsTUayQb6tgOogtO Xpqhf9tkCIFEJV25qguXNtJ0APOOjLM= X-Proofpoint-ORIG-GUID: pcbmnLBZq4TI7sGShDxX1N1cYGiTmTxW X-Authority-Analysis: v=2.4 cv=XrTK/1F9 c=1 sm=1 tr=0 ts=6a51b06f cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=Ua2K4HyBCek8nw/sr3ra2Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=o-iBtrM1MSidxli5CHcA:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzExMDAyNSBTYWx0ZWRfX92mEFqKuXxu6 BoQodhGIDvbX8leF96fozbLuteH+46KrUGOe6UkOGNLMUsTAg0LS1ZaOZ3MN0OzuIZVgOHwp72p FTEuMaOZBsTw4xMDIksz+02LUGySW/OG6wiAfgU1VJp/Lr+p0DdH6nXJB8zfU2FRp9ag+A0HK6K OZrmpzxbxoRR6q8LL5imBtdPPRg/G0oEPkCTpTWBuxlJEEBk52JdJwkt3nVnTzOI+scCzC+jsCp qHBgeEmoz2To9YOO7uIsXswdZt0EiGqju0QGodPDiXs4rDbQtbBFk4G5Bqh23lZO87DmP7cl9rY tqFRyW6zY6rm1L/qbcmsVb/KTNLoC4N+B5Xr7PgEgZvZWB3lbc6BWHSXSikyh4YX5MAQHMQpgxh D0LLgL/FnefG8x2Z47u0H+mlY8Mi/QAkH5jemSDnaRmyjgJlwfzmPp+tMz7XEe2DM4pJ6/zACHi HLn1hg7c/vX5g4zRe/A== X-Proofpoint-GUID: pcbmnLBZq4TI7sGShDxX1N1cYGiTmTxW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_07,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607110025 Hi Mark, On 11-07-2026 02:56, Mark Brown wrote: > On Sat, Jul 11, 2026 at 12:18:42AM +0530, Praveen Talari wrote: > >> The GENI SPI driver reports various transfer failures such as command >> timeouts, DMA reset timeouts, DMA transaction errors, and unexpected >> interrupt conditions. However, diagnosing the root cause of these >> failures is difficult as the hardware state is not captured when the >> error occurs. >> +#include > Should this be in rivers/soc/qcom/qcom-geni-se.c (and the first patch?) > - that way if another driver starts using them we won't multiply define > the tracepoints. Yes, you are correct but If this header in drivers/soc/qcom/qcom-geni-se.c, how it will be access trace API in other drivers like i2c, spi and uart? > >> @@ -986,10 +997,13 @@ static irqreturn_t geni_spi_isr(int irq, void *data) >> writel(0, se->base + SE_GENI_TX_WATERMARK_REG); >> dev_err(mas->dev, "Premature done. tx_rem = %d bpw%d\n", >> mas->tx_rem_bytes, mas->cur_bits_per_word); >> + trace_geni_se_regs(se); > SE_GENI_TX_WATERMARK_REG is one of the registers in the tracepoint, > perhaps trace before we write to clear it? it will be captured in m_irq register so it is not required to capture. Thanks, Praveen talari