From: Bastien Nocera <hadess@hadess.net>
To: Christian Mayer <christian@mayer-bgk.de>,
Christian Mayer <git@mayer-bgk.de>,
linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 1/3] HID: steelseries: add SteelSeries Arctis 9 support
Date: Thu, 09 Jan 2025 14:35:54 +0100 [thread overview]
Message-ID: <73e15575fba6cb1093b1b8298e29e9a52ed5930f.camel@hadess.net> (raw)
In-Reply-To: <baad8f90-e9cb-4c1d-bbbc-fa556c1c2e1a@mayer-bgk.de>
On Sun, 2025-01-05 at 11:16 +0100, Christian Mayer wrote:
>
> > On Wed, 2025-01-01 at 15:11 +0000, Christian Mayer wrote:
<snip>
> >
> > > + if (sd->quirks & STEELSERIES_ARCTIS_9) {
> > > + ret = hid_hw_open(hdev);
> >
> > Is this needed? If so, this probably needs to be added as a
> > separate
> > commit, for all headsets rather than just this one.
> Yes that's mandatory to get raw_events from the device.
> I thought about adding this to all headsets, but i was not sure if
> this
> breaks anything for the Arctis 1 headset.
>
> But i can add this for all headsets, that's fine with me.
> Would you like me to create a completely separate patch for this or
> should i submit this with the preparation patch which refactors
> steelseries_headset_fetch_battery?
Please send a patch that does it for both headsets, and I'll test it
locally.
next prev parent reply other threads:[~2025-01-09 13:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 15:11 [PATCH 0/3] " Christian Mayer
2025-01-01 15:11 ` [PATCH 1/3] " Christian Mayer
2025-01-04 11:58 ` Bastien Nocera
2025-01-05 10:16 ` Christian Mayer
2025-01-09 13:35 ` Bastien Nocera [this message]
2025-01-12 11:49 ` Christian Mayer
2025-01-04 12:45 ` Christophe JAILLET
2025-01-05 10:33 ` Christian Mayer
2025-01-01 15:11 ` [PATCH 2/3] HID: steelseries: export charging state for the SteelSeries Arctis 9 headset Christian Mayer
2025-01-04 12:02 ` Bastien Nocera
2025-01-01 15:11 ` [PATCH 3/3] HID: steelseries: export model and manufacturer Christian Mayer
2025-01-04 12:01 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e15575fba6cb1093b1b8298e29e9a52ed5930f.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=christian@mayer-bgk.de \
--cc=git@mayer-bgk.de \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®