From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
X86 ML <x86@kernel.org>, Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH -v4] checkpatch: Check for .byte-spelled insn opcodes documentation on x86
Date: Mon, 12 Oct 2020 10:40:07 -0700 [thread overview]
Message-ID: <73e18a141df7a9259ef47363152bc2595b00bda4.camel@perches.com> (raw)
In-Reply-To: <20201012173142.GI22829@zn.tnic>
On Mon, 2020-10-12 at 19:31 +0200, Borislav Petkov wrote:
> On Mon, Oct 12, 2020 at 10:17:56AM -0700, Joe Perches wrote:
> > Workie here. This is against -next.
>
> Nevermind - I had an old version in that branch.
>
> What I mind to, however, is:
>
> "adding a mechanism to only emit the message once per patched file (Joe)"
>
> This needs to happen for every .byte line which doesn't have a comment
> documenting the binutils version.
Why? I think it unnecessary.
It's noisy and would also be duplicative in the code.
/* binutils version x.y */
#define __ASM_CLAC ".byte 0x0f,0x01,0xca"
#define __ASM_STAC ".byte 0x0f,0x01,0xcb"
Both should not need separate binutils version info
if added in a patch context.
next prev parent reply other threads:[~2020-10-12 17:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 16:14 [PATCH] " Borislav Petkov
2020-10-09 18:01 ` Joe Perches
2020-10-10 10:54 ` Borislav Petkov
2020-10-10 10:55 ` [PATCH -v2] " Borislav Petkov
2020-10-10 15:27 ` [PATCH] " Joe Perches
2020-10-10 16:11 ` Borislav Petkov
2020-10-10 16:47 ` Joe Perches
2020-10-12 14:21 ` Borislav Petkov
2020-10-12 14:23 ` [PATCH -v3] " Borislav Petkov
2020-10-12 15:04 ` Joe Perches
2020-10-12 15:02 ` [PATCH] " Joe Perches
2020-10-12 17:09 ` [PATCH -v4] " Joe Perches
2020-10-12 17:15 ` Borislav Petkov
2020-10-12 17:17 ` Joe Perches
2020-10-12 17:31 ` Borislav Petkov
2020-10-12 17:40 ` Joe Perches [this message]
2020-10-12 17:55 ` Borislav Petkov
2020-10-12 18:03 ` Joe Perches
2020-10-10 15:38 ` [PATCH] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e18a141df7a9259ef47363152bc2595b00bda4.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®