From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B421A408002 for ; Tue, 19 May 2026 15:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779205581; cv=none; b=YaGF+t4iseLw6nXOTtrJhMsqVfDwCtJT7bk68y6FB0CCQOAjXulM4n13lxGO90kFArhe2MyPn9MZSte7MbGls2a7MZ7x4NV2ec16uNkNpY5KZLIwNIyAnbcTMwSNEhYQZDIiFjCn08HjnkUj9NkC7ndpfn2j3LFlAmGeuvHMc3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779205581; c=relaxed/simple; bh=5T+dGixDG5fmBL/dmq6WzOVfoP6DUYuLr5vjU9kA3wA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fIEYe8O0+i8CkGlVqpBJKzNI+riFLa5r2kAFFTfGMlJne6cXqlgJxTnmyMen+Liad5jgtzvW0iotgDQax9mC6We56Q/+uRRBdvL9z4szzMypiv31NVFVkVTSf9av7qLOFSZRAxe95BpoDMyf6ic8MWZhFKaCwirJnjWz1+J5Bjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P5o5p2/u; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P5o5p2/u" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48e82c23840so30439315e9.3 for ; Tue, 19 May 2026 08:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779205578; x=1779810378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cNEYJ0/3OL6V5KtaRvLweTOXbANv4SgmKSvooy29LIM=; b=P5o5p2/us21ERwcjXlCUCV3w2XDJiLvqzH3sMy3g5u0Czyl6cV8Td8hygZfyob/FoR wOb6omBvdJiHNXdlyvXkKW8QJ8ud0MwmMbKxmTtHlQWruz7RlIVQ3mybtTIVCB/JzC3k dmVpguypTG4gTmIKSshCHQYku/40bKcLmmt/yx0Ozro4uV3ptJhVh75rIzkjVLM7W1S4 uWR7+w45Z1kQ5hxT0WybTKy3oi3eiVdHGMPcwm0Rtsdq5Ia6RgEXXrjz893+oLUJRlS2 9gke22KZeRV3V/KAcvri8HyCCre+sTTR4Y3hujiuAPEM/uBlbIspea2JfFfWt2MI2Aj6 gVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779205578; x=1779810378; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cNEYJ0/3OL6V5KtaRvLweTOXbANv4SgmKSvooy29LIM=; b=YjcucutFch6+hRk6hsapmTyw/l0VkGcc6xYMSHBsm/xvRBoX2ouCesT6XA+8bvjoY3 eS9cPNGvEcThykFLyhgl7gBWHRqHSEeheGqiBO9egqv9n6D/SlOIiQZXkUTet5iny3dO vHYDxh3zXho+F9Ej+1LXgUVC1o/OXzXre2+RPSazw0UYRhnZmpxqpYN2Wdt1wwa09agV AUN55xZnrpyxic4wuHEqTO/e/eSJblQZen7WojveeGfngYs3Q1PbBHnbg+dyesbLiaOf DJPZPlM75Tq7w5wUwcg4JhGRP0UUIXjc8va9Q48tiTIncMKPcM0C/+OyAYqlzpnQEOb7 0J1w== X-Forwarded-Encrypted: i=1; AFNElJ+DoROQNAT4cGhI9ZoEp2/GB1QkW4ZH8xmTABW82bKJWdv/5m9tRKHFAlK3xAr6HK5HdLSlg6XYOqlnZFw=@vger.kernel.org X-Gm-Message-State: AOJu0YwfaBOQwW1zEfiVklaNYeU3E6rz4tKvI2G46s6QmJgPGIo/9HWc AKd2Tq5hUEvakM5kMah4M4QCXXyzgVJT8BKzPrG1oqlRZp7QXQH+5yJU/z+OkCgw2Fc= X-Gm-Gg: Acq92OEScjmAx4k0ntyVHi1i+zLzBRQG/3ic8zpNBl6W45jh65MqAXxiE4N13bxxch/ 6BLiZ3IHzeJRMOCoq2tPQf6CyrURYMFZ78GWzFgIHFIm635t57l/hRtCWzUZi3bPd1NmeY1FeHg tQePo2p/l25eGTVGfRMkQL2NMGpnxV7xsMHpDBE6qsa8KFH7zU133QKUu8of8xOH5u2keMO8JXp LKBhM0o/qtCj3CdcjAX/VGy9OuTChES1sYdY52+n9+1lqvJOxx5E7QOWtFZX6WuUectpLtZSpJP 3zZ5flCYFnGbEAXkplL5d/R4B6BAiZYG5WqwHLPfy4hL+wNYtRwOFxrt1wThS2aI/3nrAnxdx3X 4TMX/UMYsq6lsZ8BHPp/Gdr2umpqPhVrBBW2SGtK34ai24FSo7za0YNeVn3BMUbRCgH1YVr0H8W ubhu6nrcQZelhTtU0YEMRLgfmAwLMgChg= X-Received: by 2002:a05:600c:34cc:b0:48e:60a3:220a with SMTP id 5b1f17b1804b1-48fe59af1cemr336906785e9.0.1779205578122; Tue, 19 May 2026 08:46:18 -0700 (PDT) Received: from [10.11.12.109] ([82.76.215.73]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4862209sm333119405e9.0.2026.05.19.08.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 08:46:17 -0700 (PDT) Message-ID: <73f18a2c-e729-45d7-9376-7c0e60ed35c7@linaro.org> Date: Tue, 19 May 2026 18:46:14 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] firmware: samsung: acpm: Add TMU protocol support To: Alexey Klimov Cc: Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Lee Jones , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , =?UTF-8?Q?Andr=C3=A9_Draszik?= , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, peter.griffin@linaro.org, jyescas@google.com, kernel-team@android.com, Krzysztof Kozlowski References: <20260506-acpm-tmu-helpers-v1-0-a9cd5daf8355@linaro.org> <20260506-acpm-tmu-helpers-v1-5-a9cd5daf8355@linaro.org> <806da86b-45b7-43cc-b364-97bade8f4041@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Alexey, On 5/18/26 2:24 PM, Alexey Klimov wrote: > Thinking further about this I'd humbly suggest that even > > if (fw_err >= 0) > return 0; > > pr_debug_ratelimited("ACPM tmu call returned: %x\n", fw_err); > or pr_debug(...); > > if (fw_err == -1) > return -EACCES; > > some debug message would do. > Perhaps we need some convertation, for instance as it is done in scmi > code (scmi_to_linux_errno(), scmi_linux_errmap[]). But I don't have any > data for mapping acpm errors to some human meanings. I did that for the pmic helpers. I don't need any debug prints for gs101 TMU as I have clear instructions from firmware: 0 for success, -1 for error. You may update it for e850 later on if you need it. Cheers, ta