From: Lars Melin <larsm17@gmail.com>
To: Romain Izard <romain.izard.pro@gmail.com>,
Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] option: Do not try to bind to ADB interfaces
Date: Mon, 23 Jul 2018 22:15:03 +0700 [thread overview]
Message-ID: <73f2233a-cafd-a477-0c0a-260be832777d@gmail.com> (raw)
In-Reply-To: <20180723140220.7166-1-romain.izard.pro@gmail.com>
On 7/23/2018 21:02, Romain Izard wrote:
> Some modems now use the Android Debug Bridge to provide a debugging
> interface, and some phones can also export serial ports managed by the
> "option" driver.
>
> The ADB daemon running in userspace tries to use USB interfaces with
> bDeviceClass=0xFF, bDeviceSubClass=0x42, bDeviceProtocol=1
>
> Prevent the option driver from binding to those interfaces, as they
> will not be serial ports.
You are assuming that an interface with these attributes are always a
ADB interface - that is wrong. Vendor specific class (0xff) is not
standardized to be something specific.
> This can fix issues like:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781256
>
You are trying to solve a 4++ years old bug report where it was assumed
that the option driver was the culprit. The device in question, a
Qualcomm modem with vid/pid 05c6:9025 has never been included in option.
rgds
Lars
next prev parent reply other threads:[~2018-07-23 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 14:02 Romain Izard
2018-07-23 14:08 ` Greg Kroah-Hartman
2018-07-23 16:45 ` Romain Izard
2018-08-27 13:28 ` Johan Hovold
2018-08-27 16:15 ` Bjørn Mork
2018-08-29 7:56 ` Johan Hovold
2018-07-23 15:15 ` Lars Melin [this message]
2018-07-23 16:37 ` Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f2233a-cafd-a477-0c0a-260be832777d@gmail.com \
--to=larsm17@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome